Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 4.3.5 breaks use of OrderedSelectWidget #530

Closed
petri opened this issue May 26, 2015 · 6 comments
Closed

upgrade to 4.3.5 breaks use of OrderedSelectWidget #530

petri opened this issue May 26, 2015 · 6 comments

Comments

@petri
Copy link
Member

petri commented May 26, 2015

I have a z3c.form with a field defined thus:

extra_products = schema.List(title=u"Choose products", required=False,
                    description=u"Chosen products will be added to each order row.",
                    value_type=schema.Choice(source=ProductSourceBinder()))

As per docs, the default widget for this is the z3c.form.browser.orderedselect.OrderedSelectWidget. This was working fine before upgrade. After upgrading, the widget only shows up & down arrows, but nothing else - nothing to select from, either.

I tried switching back to 4.3.4 and also (on 4.3.5) instead of schema.List switching to schema.Set to change the default widget to regular multi select, and both such "downgraded" cases work fine.

@petri
Copy link
Member Author

petri commented May 28, 2015

I can confirm this also affects for example ftw.globalstatusmessage, another third-party package apparently using OrderedSelectWidget.

@petri petri changed the title upgrade to 4.3.5 breaks z3c.form.browser.orderedselect.OrderedSelectWidget upgrade to 4.3.5 breaks use of z3c.form.browser.orderedselect.OrderedSelectWidget May 28, 2015
@vangheem
Copy link
Member

Try downgrading to z3c.form 3.2.1.

The only difference, it seems, from 3.2.1 to 3.2.3 is that some inline javascript was moved into a file.

Can you see if the orderedselect_input.js is getting included in your rendered page? Can you check if there are javascript errors related to it?

@petri petri changed the title upgrade to 4.3.5 breaks use of z3c.form.browser.orderedselect.OrderedSelectWidget upgrade to 4.3.5 breaks use of OrderedSelectWidget May 28, 2015
@petri
Copy link
Member Author

petri commented Jun 4, 2015

orderedselect_input.js is included, yes - no JS errors on Safari on OS X

@petri
Copy link
Member Author

petri commented Jun 4, 2015

Downgrading to z3c.form 3.2.1 helps - no problem there.

@vangheem
Copy link
Member

vangheem commented Jun 4, 2015

@pbauer any idea what might be going on? You did the change.

@vangheem
Copy link
Member

vangheem commented Jul 3, 2015

@pbauer ping on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants