PLIP 13283: merge some plone.app.* packages into the Products.CMFPlone distribution
#28
Conversation
other action keys. p.a.toolbar, for example, wants to make use of link_target.
The target can be configured on a per-action basis. Useful for controlling overlays such as with plone.app.toolbar.
Move .row and .cell styles to Sunburst main_template
… ILocalPortletAssignmentManager is contained within something which does not implement ILocalPortletAssignmentManager. e.g. a Dexterity type contained within an Archetypes type. Currently @@manage-portlets breaks on Dexterity items contained within Archetypes items by way of this flaw.
This may affect plone.app.form (IOW, formlib) forms whose subscribers call plone.locking.TTWLockable.lock().
…nel item isn't visible.
Fix inherited local portlets where dexterity content is contained by non-dexterity content
Fix for #11174
…so added tests to check that you're not able to add portlets into someone else's dashboard, and that the Member role is not able to add portlets anywhere else, unless it gets the 'Manage portlets' permission
Further changes for bug #11174
Change to unify the site setup html structure
=============================================
- Check for structure:
#portal-column-content
#content
.setup-link
.documentFirstHeading
.documentDescription
#content-core
- Check for body template- class
Related changes
---------------
Templates have also changed in:
plone.app.contentrules
plone.app.controlpanel
plone.app.discussion
plone.app.registry
plone.app.users
Products.CMFPlone
Styles have been updated in plonetheme.sunburst
Change to unify the site setup html structure
=============================================
- Check for structure:
#portal-column-content
#content
.setup-link
.documentFirstHeading
.documentDescription
#content-core
- Check for body template- class
Related changes
---------------
Templates have also changed in:
plone.app.contentrules
plone.app.controlpanel
plone.app.discussion
plone.app.registry
plone.app.users
Products.CMFPlone
Styles have been updated in plonetheme.sunburst
add buildout to run tests
|
hmm, maybe the history of the merged packages (so far two) doesn't make this a very good place to get an overview… :) nevertheless if you're interested in the actual changes, search the commits for "into |
…ckages into `Products.CMFPlone`
…app/users/` (and removing the remains)
|
Phew, i fear this one is completely outdated and impossible to merge/fix. Folks, code's getting rotten if it's not eaten early. Pull requests are not a deep freezer. |
|
@jensens, yes, of course it's outdated by now. the branch and pull request were merely an experiment with regard to how to best go about merging those packages. not nearly all packages discussed in the PLIP have been merged here, but i suppose i should have put a note about this and the the branch needs to be "restarted" eventually... |
|
@witsch I thought so. I'am just in cleanup mood and looked around the branches ;) Imo we should close this one and start fresh one (or several - one for each step) to have a clean and manageable record. |
|
yes, i agree — this should probably be closed. thanks to your comment @davisagli and i discussed the timing of this again, and we think it's best to start (over) on this again when most things have been merged for plone 5, but before any final releases have been made... |
Include a note about Plone version in the README
Preliminary pull request for PLIP 13283. This is intended to make it easier to follow the PLIP's changes and discuss them.