Skip to content

Commit

Permalink
[fc] Repository: plone.app.layout
Browse files Browse the repository at this point in the history 
Branch: refs/heads/master
Date: 2022-05-19T23:03:12+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plone.app.layout@c668c72

Remove alt tags from icons within links.

Files changed:
M plone/app/layout/viewlets/menu.pt
M plone/app/layout/viewlets/toolbar.pt
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2022-05-19T23:09:08+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plone.app.layout@2586df6

add news

Files changed:
A news/309.bugfix
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2022-05-20T15:43:48+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.layout@6147620

Merge pull request #309 from plone/toolbar-icon-alt-tag

Remove alt tags from icons within links.

Files changed:
A news/309.bugfix
M plone/app/layout/viewlets/menu.pt
M plone/app/layout/viewlets/toolbar.pt
  • Loading branch information
@jensens
jensens committed May 20, 2022
1 parent d6e84ad commit 21dc43b
Showing 1 changed file with 20 additions and 18 deletions.
38 changes: 20 additions & 18 deletions last_commit.txt
View file
@@ -1,48 +1,50 @@
Repository: plone.app.contentmenu
Repository: plone.app.layout


Branch: refs/heads/master
Date: 2022-05-19T23:03:25+02:00
Date: 2022-05-19T23:03:12+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: https://github.com/plone/plone.app.contentmenu/commit/b0055f348cff59fd56d4dc4631adf79bc519bf0c
Commit: https://github.com/plone/plone.app.layout/commit/c668c72fe6675f341183463b5a1863e9326fd7d5

Remove alt tags from icons within links.

Files changed:
M plone/app/contentmenu/contentmenu.pt
M plone/app/layout/viewlets/menu.pt
M plone/app/layout/viewlets/toolbar.pt

b'diff --git a/plone/app/contentmenu/contentmenu.pt b/plone/app/contentmenu/contentmenu.pt\nindex aba5184..19beb3c 100644\n--- a/plone/app/contentmenu/contentmenu.pt\n+++ b/plone/app/contentmenu/contentmenu.pt\n@@ -21,7 +21,7 @@\n data-bs-offset="0,0"\n aria-expanded="${python:\'false\' if submenu else \'\'}">\n \n- <tal:icon tal:replace="structure python:icons.tag(menuItem.get(\'icon\',\'\') and menuItem[\'icon\'] or \'toolbar-action\', tag_alt=menuItem.get(\'id\',\'toolbarIcon\'), tag_class=\'me-1\')" />\n+ <tal:icon tal:replace="structure python:icons.tag(menuItem.get(\'icon\',\'\') and menuItem[\'icon\'] or \'toolbar-action\', tag_class=\'me-1\')" />\n \n <span class="toolbar-label">\n <span\n@@ -54,7 +54,7 @@\n data-pat-plone-modal subMenuItem/extra/modal | nothing;"\n tal:condition="subMenuItem/action">\n \n- <tal:icon tal:replace="structure python:icons.tag(\'check\' if \'active\' in extra_class else (subMenuItem.get(\'icon\') or \'dot\'), tag_alt=subMenuItem[\'title\'])" />\n+ <tal:icon tal:replace="structure python:icons.tag(\'check\' if \'active\' in extra_class else (subMenuItem.get(\'icon\') or \'dot\'))" />\n \n <tal:title\n content="structure subMenuItem/title"\n'
b'diff --git a/plone/app/layout/viewlets/menu.pt b/plone/app/layout/viewlets/menu.pt\nindex fb11e06a..64958e1f 100644\n--- a/plone/app/layout/viewlets/menu.pt\n+++ b/plone/app/layout/viewlets/menu.pt\n@@ -14,12 +14,12 @@\n \n <tal:if condition="python:actionid != \'history\'">\n <tal:icon tal:condition="python:action[\'icon\']"\n- tal:replace="structure python:icons.tag(action[\'icon\'] or \'toolbar-action\', tag_alt=action[\'id\'], tag_class=\'me-1\')" />\n+ tal:replace="structure python:icons.tag(action[\'icon\'] or \'toolbar-action\', tag_class=\'me-1\')" />\n <span class="toolbar-label" tal:content="action/title" i18n:translate="">View name</span>\n </tal:if>\n \n <tal:if tal:condition="python:actionid == \'history\'">\n- <tal:icon tal:replace="structure python:icons.tag(\'lock\' if locked else action[\'icon\'], tag_alt=action[\'id\'], tag_class=\'me-1\')" />\n+ <tal:icon tal:replace="structure python:icons.tag(\'lock\' if locked else action[\'icon\'], tag_class=\'me-1\')" />\n <span class="toolbar-label">\n <time\n class="pat-display-time"\ndiff --git a/plone/app/layout/viewlets/toolbar.pt b/plone/app/layout/viewlets/toolbar.pt\nindex c9bc183b..8549ca81 100644\n--- a/plone/app/layout/viewlets/toolbar.pt\n+++ b/plone/app/layout/viewlets/toolbar.pt\n@@ -34,7 +34,7 @@\n data-bs-offset="0,0"\n aria-expanded="false"\n tal:attributes="href personal_bar/homelink_url">\n- <tal:icon tal:replace="structure python:icons.tag(\'toolbar-action/personaltools\', tag_alt=\'portal-personaltools\', tag_class=\'me-1\')" />\n+ <tal:icon tal:replace="structure python:icons.tag(\'toolbar-action/personaltools\', tag_class=\'me-1\')" />\n <span class="toolbar-label" tal:content="personal_bar/user_name">User</span>\n </a>\n \n@@ -46,7 +46,7 @@\n </li>\n <li tal:repeat="action personal_bar/user_actions">\n <a href="${action/href}" class="dropdown-item">\n- <tal:icon replace="structure python:icons.tag(action.get(\'icon\', \'dot\'), tag_alt=\'portal-personaltools\', tag_class=\'me-1\')" />\n+ <tal:icon replace="structure python:icons.tag(action.get(\'icon\', \'dot\'), tag_class=\'me-1\')" />\n <tal:actionname tal:content="action/title">\n action title\n </tal:actionname>\n'

Repository: plone.app.contentmenu
Repository: plone.app.layout


Branch: refs/heads/master
Date: 2022-05-19T23:07:13+02:00
Date: 2022-05-19T23:09:08+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: https://github.com/plone/plone.app.contentmenu/commit/e2b5378dd5c4a62e4033042babbe2f244d1392e9
Commit: https://github.com/plone/plone.app.layout/commit/2586df6ef5e5e5aec3e5173548dc678d35dab22c

add news

Files changed:
A news/38.bugfix
A news/309.bugfix

b'diff --git a/news/38.bugfix b/news/38.bugfix\nnew file mode 100644\nindex 0000000..098bf1c\n--- /dev/null\n+++ b/news/38.bugfix\n@@ -0,0 +1,2 @@\n+Remove alt tags from icons within links.\n+[agitator]\n\\ No newline at end of file\n'
b'diff --git a/news/309.bugfix b/news/309.bugfix\nnew file mode 100644\nindex 00000000..098bf1c4\n--- /dev/null\n+++ b/news/309.bugfix\n@@ -0,0 +1,2 @@\n+Remove alt tags from icons within links.\n+[agitator]\n\\ No newline at end of file\n'

Repository: plone.app.contentmenu
Repository: plone.app.layout


Branch: refs/heads/master
Date: 2022-05-20T14:27:57+02:00
Author: agitator (agitator) <agitator@users.noreply.github.com>
Commit: https://github.com/plone/plone.app.contentmenu/commit/93e6ce82469d483eb916edf3442348d53fa9bf56
Date: 2022-05-20T15:43:48+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: https://github.com/plone/plone.app.layout/commit/6147620c46c3ed722e9be560f91f413b2273e79a

Merge pull request #38 from plone/toolbar-icon-alt-tag
Merge pull request #309 from plone/toolbar-icon-alt-tag

Remove alt tags from icons within links.

Files changed:
A news/38.bugfix
M plone/app/contentmenu/contentmenu.pt
A news/309.bugfix
M plone/app/layout/viewlets/menu.pt
M plone/app/layout/viewlets/toolbar.pt

b'diff --git a/news/38.bugfix b/news/38.bugfix\nnew file mode 100644\nindex 0000000..098bf1c\n--- /dev/null\n+++ b/news/38.bugfix\n@@ -0,0 +1,2 @@\n+Remove alt tags from icons within links.\n+[agitator]\n\\ No newline at end of file\ndiff --git a/plone/app/contentmenu/contentmenu.pt b/plone/app/contentmenu/contentmenu.pt\nindex aba5184..19beb3c 100644\n--- a/plone/app/contentmenu/contentmenu.pt\n+++ b/plone/app/contentmenu/contentmenu.pt\n@@ -21,7 +21,7 @@\n data-bs-offset="0,0"\n aria-expanded="${python:\'false\' if submenu else \'\'}">\n \n- <tal:icon tal:replace="structure python:icons.tag(menuItem.get(\'icon\',\'\') and menuItem[\'icon\'] or \'toolbar-action\', tag_alt=menuItem.get(\'id\',\'toolbarIcon\'), tag_class=\'me-1\')" />\n+ <tal:icon tal:replace="structure python:icons.tag(menuItem.get(\'icon\',\'\') and menuItem[\'icon\'] or \'toolbar-action\', tag_class=\'me-1\')" />\n \n <span class="toolbar-label">\n <span\n@@ -54,7 +54,7 @@\n data-pat-plone-modal subMenuItem/extra/modal | nothing;"\n tal:condition="subMenuItem/action">\n \n- <tal:icon tal:replace="structure python:icons.tag(\'check\' if \'active\' in extra_class else (subMenuItem.get(\'icon\') or \'dot\'), tag_alt=subMenuItem[\'title\'])" />\n+ <tal:icon tal:replace="structure python:icons.tag(\'check\' if \'active\' in extra_class else (subMenuItem.get(\'icon\') or \'dot\'))" />\n \n <tal:title\n content="structure subMenuItem/title"\n'
b'diff --git a/news/309.bugfix b/news/309.bugfix\nnew file mode 100644\nindex 00000000..098bf1c4\n--- /dev/null\n+++ b/news/309.bugfix\n@@ -0,0 +1,2 @@\n+Remove alt tags from icons within links.\n+[agitator]\n\\ No newline at end of file\ndiff --git a/plone/app/layout/viewlets/menu.pt b/plone/app/layout/viewlets/menu.pt\nindex fb11e06a..64958e1f 100644\n--- a/plone/app/layout/viewlets/menu.pt\n+++ b/plone/app/layout/viewlets/menu.pt\n@@ -14,12 +14,12 @@\n \n <tal:if condition="python:actionid != \'history\'">\n <tal:icon tal:condition="python:action[\'icon\']"\n- tal:replace="structure python:icons.tag(action[\'icon\'] or \'toolbar-action\', tag_alt=action[\'id\'], tag_class=\'me-1\')" />\n+ tal:replace="structure python:icons.tag(action[\'icon\'] or \'toolbar-action\', tag_class=\'me-1\')" />\n <span class="toolbar-label" tal:content="action/title" i18n:translate="">View name</span>\n </tal:if>\n \n <tal:if tal:condition="python:actionid == \'history\'">\n- <tal:icon tal:replace="structure python:icons.tag(\'lock\' if locked else action[\'icon\'], tag_alt=action[\'id\'], tag_class=\'me-1\')" />\n+ <tal:icon tal:replace="structure python:icons.tag(\'lock\' if locked else action[\'icon\'], tag_class=\'me-1\')" />\n <span class="toolbar-label">\n <time\n class="pat-display-time"\ndiff --git a/plone/app/layout/viewlets/toolbar.pt b/plone/app/layout/viewlets/toolbar.pt\nindex c9bc183b..8549ca81 100644\n--- a/plone/app/layout/viewlets/toolbar.pt\n+++ b/plone/app/layout/viewlets/toolbar.pt\n@@ -34,7 +34,7 @@\n data-bs-offset="0,0"\n aria-expanded="false"\n tal:attributes="href personal_bar/homelink_url">\n- <tal:icon tal:replace="structure python:icons.tag(\'toolbar-action/personaltools\', tag_alt=\'portal-personaltools\', tag_class=\'me-1\')" />\n+ <tal:icon tal:replace="structure python:icons.tag(\'toolbar-action/personaltools\', tag_class=\'me-1\')" />\n <span class="toolbar-label" tal:content="personal_bar/user_name">User</span>\n </a>\n \n@@ -46,7 +46,7 @@\n </li>\n <li tal:repeat="action personal_bar/user_actions">\n <a href="${action/href}" class="dropdown-item">\n- <tal:icon replace="structure python:icons.tag(action.get(\'icon\', \'dot\'), tag_alt=\'portal-personaltools\', tag_class=\'me-1\')" />\n+ <tal:icon replace="structure python:icons.tag(action.get(\'icon\', \'dot\'), tag_class=\'me-1\')" />\n <tal:actionname tal:content="action/title">\n action title\n </tal:actionname>\n'

0 comments on commit 21dc43b

Please sign in to comment.