Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plone.volto to the tested packages. #764

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

mauritsvanrees
Copy link
Sponsor Member

No description provided.

@mauritsvanrees
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

1 similar comment
@mauritsvanrees
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Sponsor Member Author

This fails on Jenkins on all three jobs, with five errors in plone.restapi.tests.test_services_users.TestUsersEndpoint. I restarted one of them (3.7), but that got the same errors. For example:

201 != 500

  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 628, in run
    testMethod()
  File "/home/jenkins/workspace/pull-request-6.0-3.7/src/plone.restapi/src/plone/restapi/tests/test_services_users.py", line 242, in test_add_anon_user_sends_properties_are_saved
    self.assertEqual(201, response.status_code)
  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 852, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 845, in _baseAssertEqual
    raise self.failureException(msg)

When I try it locally, the plone.restapi tests run fine.
So: no idea currently.

@mauritsvanrees
Copy link
Sponsor Member Author

Ah, locally this works:

bin/test -s plone.volto -s plone.restapi -m test_services

But this gives the same five errors:

bin/test -s plone.volto -s plone.restapi

@mauritsvanrees
Copy link
Sponsor Member Author

It now works locally. I don't know what has changed since last month. Let's try again:

@jenkins-plone-org please run jobs

tests.cfg Outdated Show resolved Hide resolved
@mauritsvanrees
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Sponsor Member Author

I checked the Jenkins 3.9 console to be sure, and plone.volto tests are indeed being run:

Running plone.volto.testing.PloneVoltoCoreLayer:IntegrationTesting tests:
  Tear down plone.restapi.testing.PloneRestApiDXPAMLayer:Integration in 0.000 seconds.
  Tear down plone.restapi.testing.PloneRestApiDXPAMLayer in 0.003 seconds.
  Tear down plone.restapi.testing.DateTimeFixture in 0.000 seconds.
  Set up plone.volto.testing.PloneVoltoCoreLayer in 1.594 seconds.
  Set up plone.volto.testing.PloneVoltoCoreLayer:IntegrationTesting in 0.000 seconds.
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
  Ran 19 tests with 0 failures, 0 errors and 0 skipped in 1.390 seconds.

Strangely, I don't see any plone.transformchain tests, but that is also the case for a current 3.9 job. Locally, bin/test -s plone.transformchain runs 25 tests. Let me ignore that for now. Enough things to work on already.

@mauritsvanrees mauritsvanrees merged commit 76613ec into 6.0 Feb 23, 2022
@mauritsvanrees mauritsvanrees deleted the test-plone-volto branch February 23, 2022 19:27
@mauritsvanrees
Copy link
Sponsor Member Author

Well, when I add a breakpoint in a plone.transformchain test, and run bin/test -u, I get into a Python prompt, so that is good. Maybe it is just not getting reported by name in the output. Can be ignored I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants