Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for 6.0.0a3 and 5.2.7 #49

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Add images for 6.0.0a3 and 5.2.7 #49

merged 1 commit into from
Jan 31, 2022

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh
Copy link
Member Author

@mauritsvanrees did 6.0.0a3 already depends on plone.volto? We are adding it later in the image.

Also, @avoinea @ericof @jensens @silviot Do we want to maintain all of them or deprecate (or just stop building) the images at some point (and rely on the historic from registry).

@mauritsvanrees
Copy link
Member

@mauritsvanrees did 6.0.0a3 already depends on plone.volto? We are adding it later in the image.

Not yet. We should probably do that for the next alpha (or first beta). The collective.folderishcontenttypes dependency is gone, which was the biggest blocker for this, IIRC.
PR is already here: plone/Plone#20
But it would be good to fix some coredev tests first, which appear when we add plone.volto to the test eggs: plone/buildout.coredev#764

@mauritsvanrees
Copy link
Member

BTW, pip version 22 is out, which means we no longer need to use the deprecated resolver option.
But it gives a problem with buildout so it may be too much trouble to update currently.

Copy link
Member

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericof ericof merged commit 0f7f92a into main Jan 31, 2022
@ericof ericof deleted the updateimages branch January 31, 2022 21:15
@jensens
Copy link
Member

jensens commented Feb 1, 2022

pip 22 works fine in a3. I use it in a project (with mxdev 2)

@avoinea
Copy link
Member

avoinea commented Feb 2, 2022

@jensens Should we then upgrade?

ENV PIP_PARAMS="--use-deprecated legacy-resolver"
ENV PIP_VERSION=21.3

@jensens
Copy link
Member

jensens commented Feb 3, 2022

@jensens Should we then upgrade?

ENV PIP_PARAMS="--use-deprecated legacy-resolver"
ENV PIP_VERSION=21.3

Yes, pip 22 works fine with Plone and without the legacy resolver!
But it should reflect in buildout.coredev pip pins (versions.cfg/requirements.cfg) as well then, right?

@mauritsvanrees
Copy link
Member

But it should reflect in buildout.coredev pip pins (versions.cfg/requirements.cfg) as well then, right?

I tried latest pip in coredev a few days ago, but it failed.
I updated my WIP PR with the newest versions, but still fails.
Needs a fix in buildout

BTW, pip 22.0.3 is out with a another fix by me for the new resolver. Should only matter in corner cases.

@jensens
Copy link
Member

jensens commented Feb 3, 2022

ah, buildout, I use it with pip only in some projects and that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants