Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular dependency check must be version constrained #168

Open
gforcada opened this issue Jul 18, 2023 · 1 comment
Open

circular dependency check must be version constrained #168

gforcada opened this issue Jul 18, 2023 · 1 comment
Labels
01 type: bug something does not work 13 prio: normal needs a fix, but not now 42 lvl: moderate fair project insight needed

Comments

@gforcada
Copy link
Member

Otherwise a new package gets released and it is being used on the circular dependency check 😕

With the following changes it should be fine to get it to work again 🍀

constrain_package_deps = true
deps =
    ...
    -c my-constraints-file.txt

This is even more visible when one is still on Plone 5.2 and tries to configure an internal package 🤚🏾

But as we generalize plone/meta enough to get collective packages to be covered, and for that with multiple python and plone versions support, it will be a must.

@gforcada gforcada added 01 type: bug something does not work 13 prio: normal needs a fix, but not now 42 lvl: moderate fair project insight needed labels Jul 18, 2023
@gforcada
Copy link
Member Author

There is already an option to set a constraints.txt but we are missing the constrain_package_deps still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug something does not work 13 prio: normal needs a fix, but not now 42 lvl: moderate fair project insight needed
Projects
None yet
Development

No branches or pull requests

1 participant