Make object_provides work also on tuple #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -549,12 +549,11 @@ def find(context=None, depth=None, **kwargs): | |||
| # Convert interfaces to their identifiers | |||
| object_provides = query.get('object_provides', []) | |||
| if object_provides: | |||
| if not isinstance(object_provides, list): | |||
| if not isinstance(object_provides, (list, tuple)): | |||
There was a problem hiding this comment.
Why not make the function work with all iterable types? This would work:
import collections
if isinstance(object_provides, collections.Iterable):
There was a problem hiding this comment.
Yeah, you are right, this is not the best possible solution.
Anyway checking for collections.Iterable leads you to problem in case of dicts and strings:
>>> a = {}
>>> b =''
>>> import collections
>>> isinstance(a, collections.Iterable)
True
>>> isinstance(b, collections.Iterable)
True
This would lead to additional "if"s :)
|
please add a note to the changelog |
|
@jensens done ;) |
adamcheasley
pushed a commit
that referenced
this pull request
Jul 30, 2015
Make object_provides work also on tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266