Tox improvements and added black as formatter #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loechel thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
[ci skip]
The code might still work, but it is no longer tested. You can use releases in the 1.10 series on the older versions.
Theoretically our tests might work, but there is definitely other code that would have test failures, so you should not use it on 5.2. And no easy way to already test on 6.0. But we have buildout.coredev and Jenkins.
This was referenced Feb 28, 2021
I thought I did that already, but this was only in tox.ini. It was still in the travis config.
Seems better, as the other envs at most use 3.8. And on Travis the docs env fails, with no output. Maybe this helps.
See also the closed PR #455 where I try a few Python versions and add some comments.
Further improvements to the tox PR
|
Travis should be green by now, but let's not forget Jenkins: @jenkins-plone-org please run jobs |
ale-rt
approved these changes
Mar 4, 2021
|
@plone/framework-team I would say that given no one spoke against #450 since quite some days this is fine to merge |
|
@ale-rt please feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.