Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements to the tox PR #453

Merged
merged 7 commits into from Mar 4, 2021

Conversation

mauritsvanrees
Copy link
Sponsor Member

This is a PR for merging into the branch of PR #431

@loechel I already merged master into your branch, because there were two minor conflicts.

For this PR, see the individual commits.
It also drops support for Plone 5.1 and earlier. See also #450

Locally, the 2.7 tests fail, but that has a weird cause. I will open an issue for that.
The other tox tests pass.

The code might still work, but it is no longer tested.
You can use releases in the 1.10 series on the older versions.
Theoretically our tests might work, but there is definitely other code that would have test failures,
so you should not use it on 5.2.
And no easy way to already test on 6.0.  But we have buildout.coredev and Jenkins.
@thet
Copy link
Member

thet commented Mar 1, 2021

@mauritsvanrees can this be merged to master as soon as the travis failures are resolved?

and should we also switch to github actions? I'm thinking of adding support for that.

@mauritsvanrees
Copy link
Sponsor Member Author

I would like to use GitHub Actions, yes. The plug on travis-co.org has not been pulled yet, but that is a matter of time.

This part of the PR drops testing on 5.1 and earlier, which should be okay, but we may want to wait on a resolution of the discussion in #450

Other than the supported versions, biggest question of this PR and the parent PR of Alexander, is if the docs tox env still works, and if this is needed for building the documentation on docs.plone.org. Currently it fails on Travis, so maybe there is some more work to do.

I thought I did that already, but this was only in tox.ini.  It was still in the travis config.
Seems better, as the other envs at most use 3.8.
And on Travis the docs env fails, with no output.  Maybe this helps.
mauritsvanrees added a commit that referenced this pull request Mar 4, 2021
On Travis the sphinx docs fail with no output after ten minutes.

This PR not meant to be merged, this is only for investigation.
Based on #453
See also the closed PR #455 where I try a few Python versions and add some comments.
@mauritsvanrees
Copy link
Sponsor Member Author

Travis is green. I merge to the PR branch of @loechel

@mauritsvanrees mauritsvanrees merged commit 4db0bb5 into tox-improvements+black Mar 4, 2021
@mauritsvanrees mauritsvanrees deleted the maurits/tox branch March 4, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants