Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config with default template #512

Merged
merged 12 commits into from
Apr 28, 2024
Merged

Conversation

gforcada
Copy link
Sponsor Member

No description provided.

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada force-pushed the config-with-default-template-0beddf5d branch 4 times, most recently from f5a7442 to 8d54e32 Compare October 15, 2023 17:53
@gforcada gforcada force-pushed the config-with-default-template-0beddf5d branch from 8d54e32 to 24a5c08 Compare March 4, 2024 06:30
@gforcada gforcada force-pushed the config-with-default-template-0beddf5d branch from 24a5c08 to 16a3d10 Compare April 28, 2024 09:00
@gforcada gforcada force-pushed the config-with-default-template-0beddf5d branch 3 times, most recently from 72b45c2 to 5713ebb Compare April 28, 2024 09:14
@gforcada gforcada force-pushed the config-with-default-template-0beddf5d branch from 5713ebb to d5c64be Compare April 28, 2024 10:53
@gforcada
Copy link
Sponsor Member Author

Finally this is working 🎉 the coverage GHA was failing due to a setting in setup.cfg 😕

We should probably clean up the configuration files, as there are quite a mix of things: buildout/tox/make... and probably outdated configuration all over 😓 but let's do that on a separate PR

@gforcada
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit 7cb4816 into master Apr 28, 2024
16 checks passed
@gforcada gforcada deleted the config-with-default-template-0beddf5d branch April 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants