Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown menu is not visible in certain screen sizes #24

Closed
rioksane opened this issue Nov 6, 2022 · 1 comment · Fixed by #63
Closed

Dropdown menu is not visible in certain screen sizes #24

rioksane opened this issue Nov 6, 2022 · 1 comment · Fixed by #63
Labels
01 type: bug something does not work

Comments

@rioksane
Copy link
Collaborator

rioksane commented Nov 6, 2022

Dropdown menu is not visible from 992px through 1329px width thus making site navigation impossible media query hides the hamburger. the culprit is https://github.com/media only screen and (max-width: 1329px) and (min-width: 992px) display: none!important

Example:
Screenshot 2022-11-06 at 17 21 04

@rioksane rioksane added the 01 type: bug something does not work label Nov 6, 2022
@rioksane rioksane transferred this issue from plone/ploneorg.core Dec 2, 2022
@Fosten
Copy link
Contributor

Fosten commented Dec 3, 2022

If you change https://github.com/collective/volto-dropdownmenu/blob/2296741efd15bd3730fe7e4cf7a2a101f62ec880/src/customizations/components/theme/Navigation/Navigation.jsx#L138 from div className="hamburger-wrapper mobile tablet only" to div className="hamburger-wrapper mobile tablet computer only" the hamburger will display in 992px through 1329px (anonymous) and 1072px through 1409px (logged in).

However, the volto-dropdownmenu Navigation.jsx is several commits behind volto's Navigation.jsx latest changes, so adding another template override may not be ideal. Is there a better way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug something does not work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants