[Breaking] Removing id from form field wrapper #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Either the wrapper should have a unique ID or the field, not both. |
tisto
requested changes
Jan 6, 2021
There was a problem hiding this comment.
@iFlameing seems you need to amend a Cypress test. I am actually wondering why we only have to amend one Cypress test. Seems we do not have a good forms test coverage.
|
Note: we remove the id from the wrapper. We have to make sure the fieldset is in the ID of the input field itself to avoid collisions when using the same form fields in different fieldsets. |
tiberiuichim
approved these changes
Jan 9, 2021
sneridagh
changed the title
|
@plone/volto-team Timo and I think that the PR might be potentially breaking since someone might rely on the ids for their acceptance tests, so I marked it as breaking and schedule it for the next major. |
|
@iFlameing please can you write docs about this breaking change? docs/source/upgrade-guide/index/md |
|
@sneridagh yes! |
* master: Back to development Release 10.10.0 Prepare for release Adding classname in TextWidget and objectBrowserBody so that we can t… (#2148) Fix breadcrumbs for folder contents in multilingual sites (#2147) Add support for nav_title in breadcrumbs and navigation (#2145) Critical css (#2136) Remove git add . from releasers Clean mess from tar gz tests
tisto
reviewed
Jan 26, 2021
|
|
||
| We have removed the id from the FormFieldWrapper because it is coincide with the label id if we don't provide the fieldset. | ||
| If you have cypress test which depends on this id then just remove the id from the test and if test fails then just | ||
| add `.react-select-container` instead of your id. |
There was a problem hiding this comment.
@iFlameing maybe we can show an example diff here or at least point to this PR, so people can check what actually changed.
tisto
approved these changes
Jan 26, 2021
sneridagh
added a commit
that referenced
this pull request
Jan 26, 2021
* master: Upgrade to React 13.14.0 (#2156) Include reference to PR and slightly amend docs [Breaking] Removing id from form field wrapper (#2102) Amend documentation [Breaking] Listing default view (#2043) Upgrade react-select (#2153) Better handling of a condition in the new breadcrumbs (#2151) Upgradesongenerator (#2150) Sorry, pushed to master unadvertently = Revert "Upgrade react-select" Upgrade react-select
sneridagh
added a commit
that referenced
this pull request
Jan 26, 2021
* master: (57 commits) Remove any trace from the nav_title, since it will be integrated in p.restapi responses (#2155) Upgrade to React 13.14.0 (#2156) Include reference to PR and slightly amend docs [Breaking] Removing id from form field wrapper (#2102) Amend documentation [Breaking] Listing default view (#2043) Upgrade react-select (#2153) Better handling of a condition in the new breadcrumbs (#2151) Upgradesongenerator (#2150) Sorry, pushed to master unadvertently = Revert "Upgrade react-select" Upgrade react-select Back to development Release 10.10.0 Prepare for release Adding classname in TextWidget and objectBrowserBody so that we can t… (#2148) Fix breadcrumbs for folder contents in multilingual sites (#2147) Add support for nav_title in breadcrumbs and navigation (#2145) Critical css (#2136) Remove git add . from releasers Clean mess from tar gz tests ...
sneridagh
added a commit
that referenced
this pull request
Jan 26, 2021
* master: (38 commits) Remove any trace from the nav_title, since it will be integrated in p.restapi responses (#2155) Upgrade to React 13.14.0 (#2156) Include reference to PR and slightly amend docs [Breaking] Removing id from form field wrapper (#2102) Amend documentation [Breaking] Listing default view (#2043) Upgrade react-select (#2153) Better handling of a condition in the new breadcrumbs (#2151) Upgradesongenerator (#2150) Sorry, pushed to master unadvertently = Revert "Upgrade react-select" Upgrade react-select Back to development Release 10.10.0 Prepare for release Adding classname in TextWidget and objectBrowserBody so that we can t… (#2148) Fix breadcrumbs for folder contents in multilingual sites (#2147) Add support for nav_title in breadcrumbs and navigation (#2145) Critical css (#2136) Remove git add . from releasers Clean mess from tar gz tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that we don't need this or we have to change the "field" to something like "wrapper" so that if someone doesn't pass the fieldset we are assigning two ids with the same value. The Form.Field and label you can see by visiting these two links
https://github.com/plone/volto/blob/master/src/components/manage/Widgets/FormFieldWrapper.jsx#L106
https://github.com/plone/volto/blob/master/src/components/manage/Widgets/FormFieldWrapper.jsx#L113