[Breaking] Removing id from form field wrapper

CHANGELOG.md

@@ -17,6 +17,7 @@
 ### Internal
 
 - Translations german: Unauthorized, Login/Register @ksuess
+- Removing id from FormFieldWrapper @iFlameing
 
 ## 10.6.1 (2020-12-21)
 

cypress/integration/dexterity-controlpanel-schema.js

@@ -31,9 +31,7 @@ if (Cypress.env('API') !== 'guillotina') {
 
       // Add field
       cy.get('button[id=addfield]').click();
-      cy.get('.modal [id="field-factory"] .react-select-container')
-        .click()
-        .type('Choice{enter}');
+      cy.get('.modal .react-select-container').click().type('Choice{enter}');
       cy.get('.modal input[id="field-title"]')
         .type('Color')
         .should('have.value', 'Color');
@@ -54,7 +52,7 @@ if (Cypress.env('API') !== 'guillotina') {
       cy.get(
         '[data-rbd-draggable-id="Color"] .toolbar button[aria-label="Edit"]',
       ).click();
-      cy.get('.modal [id="field-parentFieldSet"] .react-select-container')
+      cy.get('.modal .react-select-container')
         .click()
         .type('Specifications{enter}');
       cy.get('.modal textarea[id="field-values"]').type(

cypress/integration/recurrence-widget.js

@@ -56,7 +56,7 @@ if (Cypress.env('API') === 'plone') {
       cy.get('.modal #recurrenceEndsUntil').check({ force: true });
 
       //test add date
-      cy.get('.modal #field-addDate input').type('{selectall}05/20/2020');
+      cy.get('.modal input').type('{selectall}05/20/2020');
       cy.get('.modal .occurences .list > .item').should('have.length', 14);
 
       //test exclude date
@@ -88,7 +88,7 @@ if (Cypress.env('API') === 'plone') {
     it.skip('Test Monday and Friday recurrence', function () {
       //change freq
 
-      cy.get('.modal .field#field-freq')
+      cy.get('.modal .field .react-select-container')
         .click()
         .type('Monday and Friday {enter}');
       cy.get('.modal .occurences .list > .item').should('have.length', 4);
@@ -126,7 +126,9 @@ if (Cypress.env('API') === 'plone') {
 
     it.skip('Test Weekday recurrence', function () {
       //change freq
-      cy.get('.modal .field#field-freq').click().type('Weekday {enter}');
+      cy.get('.modal .field .react-select-container')
+        .click()
+        .type('Weekday {enter}');
       cy.get('.modal .occurences .list > .item').should('have.length', 10);
 
       //test recurrence end after N recurrences
@@ -165,7 +167,9 @@ if (Cypress.env('API') === 'plone') {
 
     it.skip('Test Weekly recurrence', function () {
       //change freq
-      cy.get('.modal .field#field-freq').click().type('Weekly {enter}');
+      cy.get('.modal .field .react-select-container')
+        .click()
+        .type('Weekly {enter}');
       cy.get('.modal .byday-field .ui.button.active').click(); //deactivate selected days
 
       cy.get('.modal .byday-field .ui.button').contains('Tue').click(); //select Tuesday
@@ -209,7 +213,9 @@ if (Cypress.env('API') === 'plone') {
 
     it.skip('Test Monthly recurrence', function () {
       //change freq
-      cy.get('.modal .field#field-freq').click().type('Monthly {enter}');
+      cy.get('.modal .field .react-select-container')
+        .click()
+        .type('Monthly {enter}');
 
       cy.get('.modal input#bymonthday').should('have.attr', 'value', '4');
       cy.get('.modal .occurences .list .item:last-of-type .content').contains(
@@ -278,7 +284,9 @@ if (Cypress.env('API') === 'plone') {
 
     it('Test Yearly recurrence', function () {
       //change freq
-      cy.get('.modal .field#field-freq').click().type('Yearly {enter}');
+      cy.get('.modal .field .react-select-container')
+        .click()
+        .type('Yearly {enter}');
 
       cy.get('.modal #until-date').type('{selectall}12/31/2030');
       cy.get('.modal .occurences .list > .item').should('have.length', 11);

src/components/manage/Blocks/Image/__snapshots__/ImageSidebar.test.jsx.snap

@@ -30,7 +30,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
   >
     <div
       className="inline field text"
-      id="field-external"
     >
       <div
         className="ui grid"
@@ -108,7 +107,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
     </div>
     <div
       className="inline field text"
-      id="field-alt"
     >
       <div
         className="ui grid"
@@ -329,7 +327,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
     </div>
     <div
       className="inline field"
-      id="field-image_size"
     >
       <div
         className="ui grid"
@@ -437,7 +434,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
     >
       <div
         className="inline field text"
-        id="field-link"
       >
         <div
           className="ui grid"
@@ -515,7 +511,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
       </div>
       <div
         className="inline field"
-        id="field-openLinkInNewTab"
       >
         <div
           className="ui grid"

src/components/manage/Blocks/LeadImage/__snapshots__/LeadImageSidebar.test.jsx.snap

@@ -24,7 +24,6 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
   >
     <div
       className="inline field text"
-      id="field-alt"
     >
       <div
         className="ui grid"
@@ -276,7 +275,6 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
     >
       <div
         className="inline field text"
-        id="field-link"
       >
         <div
           className="ui grid"
@@ -354,7 +352,6 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
       </div>
       <div
         className="inline field"
-        id="field-openLinkInNewTab"
       >
         <div
           className="ui grid"

src/components/manage/Blocks/Listing/__snapshots__/ListingData.test.jsx.snap

@@ -309,7 +309,6 @@ exports[`renders an Listing Data Sidebar component 1`] = `
   </div>
   <div
     className="inline field"
-    id="field-listingblock-sort-on-reverse"
   >
     <div
       className="ui grid"
@@ -351,7 +350,6 @@ exports[`renders an Listing Data Sidebar component 1`] = `
   </div>
   <div
     className="inline field text"
-    id="field-limit"
   >
     <div
       className="ui grid"
@@ -396,7 +394,6 @@ exports[`renders an Listing Data Sidebar component 1`] = `
   </div>
   <div
     className="inline field text"
-    id="field-itembatchsize"
   >
     <div
       className="ui grid"

src/components/manage/Blocks/Listing/__snapshots__/ListingMore.test.jsx.snap

@@ -4,7 +4,6 @@ exports[`renders an Listing Data Sidebar component 1`] = `
 Array [
   <div
     className="inline field text"
-    id="field-linkTitle"
   >
     <div
       className="ui grid"
@@ -49,7 +48,6 @@ Array [
   </div>,
   <div
     className="inline field text"
-    id="field-linkHref"
   >
     <div
       className="ui grid"

src/components/manage/Blocks/Listing/__snapshots__/ListingSidebar.test.jsx.snap

@@ -331,7 +331,6 @@ exports[`renders a Listing Block Sidebar component 1`] = `
         </div>
         <div
           class="inline field"
-          id="field-listingblock-sort-on-reverse"
         >
           <div
             class="ui grid"
@@ -369,7 +368,6 @@ exports[`renders a Listing Block Sidebar component 1`] = `
         </div>
         <div
           class="inline field text"
-          id="field-limit"
         >
           <div
             class="ui grid"
@@ -409,7 +407,6 @@ exports[`renders a Listing Block Sidebar component 1`] = `
         </div>
         <div
           class="inline field text"
-          id="field-itembatchsize"
         >
           <div
             class="ui grid"
@@ -465,7 +462,6 @@ exports[`renders a Listing Block Sidebar component 1`] = `
     >
       <div
         class="inline field text"
-        id="field-linkTitle"
       >
         <div
           class="ui grid"
@@ -505,7 +501,6 @@ exports[`renders a Listing Block Sidebar component 1`] = `
       </div>
       <div
         class="inline field text"
-        id="field-linkHref"
       >
         <div
           class="ui grid"

src/components/manage/Blocks/Maps/__snapshots__/MapsSidebar.test.jsx.snap

@@ -16,7 +16,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
   >
     <div
       className="inline field text"
-      id="field-external"
     >
       <div
         className="ui grid"

src/components/manage/Blocks/Video/__snapshots__/VideoSidebar.test.jsx.snap

@@ -16,7 +16,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
   >
     <div
       className="inline field text"
-      id="field-external"
     >
       <div
         className="ui grid"
@@ -94,7 +93,6 @@ exports[`renders an Image Block Sidebar component 1`] = `
     </div>
     <div
       className="inline field text"
-      id="field-video-preview-image"
     >
       <div
         className="ui grid"

src/components/manage/Preferences/__snapshots__/ChangePassword.test.jsx.snap

@@ -21,7 +21,6 @@ exports[`ChangePassword renders a change password component 1`] = `
         >
           <div
             className="inline required field help"
-            id="field-oldPassword"
           >
             <div
               className="ui grid"
@@ -80,7 +79,6 @@ exports[`ChangePassword renders a change password component 1`] = `
           </div>
           <div
             className="inline required field help"
-            id="field-newPassword"
           >
             <div
               className="ui grid"
@@ -139,7 +137,6 @@ exports[`ChangePassword renders a change password component 1`] = `
           </div>
           <div
             className="inline required field help"
-            id="field-newPasswordRepeat"
           >
             <div
               className="ui grid"

src/components/manage/Preferences/__snapshots__/PersonalInformation.test.jsx.snap

@@ -17,7 +17,6 @@ exports[`PersonalInformation renders a personal information component 1`] = `
       >
         <div
           className="inline field help text"
-          id="field-fullname"
         >
           <div
             className="ui grid"
@@ -75,7 +74,6 @@ exports[`PersonalInformation renders a personal information component 1`] = `
         </div>
         <div
           className="inline required field help text"
-          id="field-email"
         >
           <div
             className="ui grid"
@@ -133,7 +131,6 @@ exports[`PersonalInformation renders a personal information component 1`] = `
         </div>
         <div
           className="inline field help"
-          id="field-portrait"
         >
           <div
             className="ui grid"
@@ -221,7 +218,6 @@ exports[`PersonalInformation renders a personal information component 1`] = `
         </div>
         <div
           className="inline field help text"
-          id="field-home_page"
         >
           <div
             className="ui grid"
@@ -279,7 +275,6 @@ exports[`PersonalInformation renders a personal information component 1`] = `
         </div>
         <div
           className="inline field help text"
-          id="field-location"
         >
           <div
             className="ui grid"
@@ -413,7 +408,6 @@ exports[`PersonalInformation renders a personal information component embedded i
       >
         <div
           className="inline field help text"
-          id="field-fullname"
         >
           <div
             className="ui grid"
@@ -471,7 +465,6 @@ exports[`PersonalInformation renders a personal information component embedded i
         </div>
         <div
           className="inline required field help text"
-          id="field-email"
         >
           <div
             className="ui grid"
@@ -529,7 +522,6 @@ exports[`PersonalInformation renders a personal information component embedded i
         </div>
         <div
           className="inline field help"
-          id="field-portrait"
         >
           <div
             className="ui grid"
@@ -617,7 +609,6 @@ exports[`PersonalInformation renders a personal information component embedded i
         </div>
         <div
           className="inline field help text"
-          id="field-home_page"
         >
           <div
             className="ui grid"
@@ -675,7 +666,6 @@ exports[`PersonalInformation renders a personal information component embedded i
         </div>
         <div
           className="inline field help text"
-          id="field-location"
         >
           <div
             className="ui grid"

src/components/manage/Preferences/__snapshots__/PersonalPreferences.test.jsx.snap

@@ -17,7 +17,6 @@ exports[`PersonalPreferences renders a personal preferences component 1`] = `
       >
         <div
           className="inline field help"
-          id="field-language"
         >
           <div
             className="ui grid"

src/components/manage/Widgets/FormFieldWrapper.jsx

@@ -75,7 +75,6 @@ class FormFieldWrapper extends Component {
       description,
       required,
       error,
-      fieldSet,
       wrapped,
       columns,
       draggable,
@@ -103,7 +102,6 @@ class FormFieldWrapper extends Component {
         required={required}
         error={error.length > 0}
         className={cx(description ? 'help' : '', className)}
-        id={`${fieldSet || 'field'}-${id}`}
       >
         <Grid>
           <Grid.Row stretched>

src/components/manage/Widgets/__snapshots__/AlignWidget.test.jsx.snap

@@ -3,7 +3,6 @@
 exports[`renders an align widget component 1`] = `
 <div
   className="inline field align-widget"
-  id="field-align"
 >
   <div
     className="ui grid"