Volto slate upgrade guide cleanup #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct Slate versus `slate` usage
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Two unresolved questions from:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
avoinea
approved these changes
Jul 29, 2022
More the latter because, we do not know that yet. We will assign Volto releases to Plone versions but we can't tell upfront. I have a plan to write down the Plone's product strategy and discuss it during the conf with the Release team and people interested. We did this "deprecated but will be removed two majors from now" before, it worked well. Allows people to adjust.
We could throw a console message if the configuration is set to draftJS, but never did it. |
sneridagh
approved these changes
Jul 29, 2022
sneridagh
added a commit
that referenced
this pull request
Aug 3, 2022
* master: (36 commits) fix propTypes warning for Pagination component (#3543) Update documentation on how to write a Slate plugin (#3532) Updatebrowserlist (#3526) Back to development (@plone/volto-testing) Release @plone/volto-testing 2.0.1 Prepare for release Upgrade `cypress-axe` since it was forcing `cypress` < 10 version. Back to development (@plone/volto-testing) Release @plone/volto-testing 2.0.0 Upgrade to Cypress 10 Back to development Release 16.0.0-alpha.20 Prepare for release Migrate to Cypress 10 (#3541) Fixed Storybook configuration for add-ons (#3357) make Search page title translatable (#3538) Volto slate upgrade guide cleanup (#3529) Back to development Release 16.0.0-alpha.19 Allow stripping elements in the headlines (#3523) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the missed review items from #3508