Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newsitem view blocks wrapper className #4443

Merged
merged 6 commits into from Mar 8, 2023

Conversation

nzambello
Copy link
Sponsor Member

No description provided.

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 885f5de
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64057397f2425900086924fe
😎 Deploy Preview https://deploy-preview-4443--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Mar 1, 2023

Passing run #4247 ↗︎

0 14 0 0 Flakiness 0

Details:

test: update eventview snapshots
Project: Volto Commit: 8b3222227d
Status: Passed Duration: 03:40 💡
Started: Mar 6, 2023 9:56 AM Ended: Mar 6, 2023 9:59 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching the codebase shows viewwrapper also in EventView. Does it need to be fixed there too?

Please add a changelog entry in the news folder.

@sneridagh sneridagh merged commit 90c72c6 into master Mar 8, 2023
@sneridagh sneridagh deleted the fix_newsitemview_className branch March 8, 2023 11:26
sneridagh pushed a commit that referenced this pull request Mar 8, 2023
Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh added a commit that referenced this pull request Mar 8, 2023
Co-authored-by: Nicola Zambello <nzambello@protonmail.com>
Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh pushed a commit that referenced this pull request Mar 12, 2023
Co-authored-by: David Glick <david@glicksoftware.com>
erral pushed a commit that referenced this pull request Mar 18, 2023
Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh added a commit that referenced this pull request May 10, 2023
* master: (23 commits)
  Fix training urls (Remove /5/) (#4502)
  Release 17.0.0-alpha.1
  Changelog
  Serve static assets with an efficient cache policy (#2216)
  Release 16.15.0. Update Changelog. (#4485)
  Improvements to dev proxy (#4434)
  fix: newsitem view blocks wrapper className (#4443)
  Fix history view dropdown for first entry, showing 'Revert to this version option' always (#4471)
  Teaser block docs (#4461)
  Fix order of row of long table  in edit and view mode. (#4472)
  Improve flaky test in autofocus Cypress tests (#4475)
  Use popperjs in BlockChooser, move the markup to the bottom of the bo… (#4141)
  Change from links to inline literals in `CHANGELOG.md` to fix linkche… (#4470)
  Release generate-volto 7.0.0-alpha.2
  Improve stylelint config in generator, include scss support (#4469)
  Fix weird GHA failure on config option not supported (#4466)
  Release generate-volto 7.0.0-alpha.1
  Fix ESlint failure for the generator (#4465)
  Change towncrier job name (#4462)
  Release 17.0.0-alpha.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants