Fix history view dropdown for first entry, showing 'Revert to this version option' always #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion option' always
✅ Deploy Preview for volto canceled.
|
Passing run #4282 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
davisagli
approved these changes
Mar 7, 2023
| render() { | ||
| processHistoryEntries = () => { | ||
| // Getting the history entries from the props | ||
| // No clue why the reverse(concat()) is necessary |
There was a problem hiding this comment.
I guess someone just didn't want to figure out how to write a for loop to go through the entries in reverse order?
|
|
||
| return item; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
You could use lodash.find to add is_current: true to the first item that has type: 'versioning' instead of adding show_revert_true to all the others. And then check for is_current below.
But, this is good enough.
There was a problem hiding this comment.
@davisagli refactored using find, I thought it would return all the matching elements. Thanks for the suggestion!
sneridagh
added a commit
that referenced
this pull request
Mar 8, 2023
…rsion option' always (#4471)
sneridagh
added a commit
that referenced
this pull request
Mar 12, 2023
…rsion option' always (#4471)
sneridagh
added a commit
that referenced
this pull request
May 10, 2023
* master: (23 commits) Fix training urls (Remove /5/) (#4502) Release 17.0.0-alpha.1 Changelog Serve static assets with an efficient cache policy (#2216) Release 16.15.0. Update Changelog. (#4485) Improvements to dev proxy (#4434) fix: newsitem view blocks wrapper className (#4443) Fix history view dropdown for first entry, showing 'Revert to this version option' always (#4471) Teaser block docs (#4461) Fix order of row of long table in edit and view mode. (#4472) Improve flaky test in autofocus Cypress tests (#4475) Use popperjs in BlockChooser, move the markup to the bottom of the bo… (#4141) Change from links to inline literals in `CHANGELOG.md` to fix linkche… (#4470) Release generate-volto 7.0.0-alpha.2 Improve stylelint config in generator, include scss support (#4469) Fix weird GHA failure on config option not supported (#4466) Release generate-volto 7.0.0-alpha.1 Fix ESlint failure for the generator (#4465) Change towncrier job name (#4462) Release 17.0.0-alpha.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.