Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the resolution of the react-error-overlay package to 6.0.9 #4687

Merged
merged 2 commits into from Apr 13, 2023

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Apr 13, 2023

When an error occurs, the screen appears to be frozen, but the thing is that an empty iframe is covering the whole page, making impossible to click on anything. This is caused by react-error-overlay > 6.0.9 in latests Razzle.

A console log is also there: Uncaught ReferenceError: process is not defined.

The latests versions of react-error-overlay only works well together with react-scripts which Razzle is not using. So we are on our own on this one.

All projects using Volto 16 onwards should update their package.json to use it.

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit c313aa0
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6437c5500914790008208fff

@cypress
Copy link

cypress bot commented Apr 13, 2023

Passing run #4912 ↗︎

0 489 20 0 Flakiness 0

Details:

Changelog
Project: Volto Commit: c313aa0c83
Status: Passed Duration: 13:45 💡
Started: Apr 13, 2023 9:06 AM Ended: Apr 13, 2023 9:20 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sneridagh sneridagh merged commit de57cf2 into master Apr 13, 2023
52 of 53 checks passed
@sneridagh sneridagh deleted the forceresolutionofreacterroroverlayto6.0.9 branch April 13, 2023 12:45
sneridagh added a commit that referenced this pull request Apr 17, 2023
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant