Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Volto contributing to align with and refer to the new Plone co… #4634

Merged
merged 4 commits into from Apr 8, 2023

Conversation

stevepiercy
Copy link
Collaborator

…re code contributing requirements

Refs: plone/documentation#1478 and plone/documentation#1278

Do not merge until the documentation PR is merged, as this PR depends on the resolution of intersphinx references.

…re code contributing requirements

Refs: plone/documentation#1478 and plone/documentation#1278

Do not merge until the documentation PR is merged, as this PR depends on the resolution of intersphinx references.
@stevepiercy stevepiercy self-assigned this Apr 2, 2023
@netlify
Copy link

netlify bot commented Apr 2, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit d358e3e
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6431e36938bd960008c52717
😎 Deploy Preview https://deploy-preview-4634--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Apr 2, 2023

Passing run #4848 ↗︎

0 489 20 0 Flakiness 0

Details:

Reorder and reword bits to improve flow and sequence of how to contribute to Vol...
Project: Volto Commit: d358e3e888
Status: Passed Duration: 12:36 💡
Started: Apr 8, 2023 10:01 PM Ended: Apr 8, 2023 10:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stevepiercy
Copy link
Collaborator Author

The Documentation PR dependency has been merged. YAY!

Please review this PR @fredvd @ksuess @sneridagh @mauritsvanrees @tiberiuichim @jensens at your earliest convenience. Thank you!

Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davisagli davisagli mentioned this pull request Apr 8, 2023
…bute to Volto

- Add labels for section headings
@davisagli davisagli merged commit 00029a2 into master Apr 8, 2023
39 checks passed
@davisagli davisagli deleted the contributing-plone-core-code branch April 8, 2023 22:15
sneridagh added a commit that referenced this pull request Apr 10, 2023
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
sneridagh added a commit that referenced this pull request Apr 17, 2023
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants