Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing block #747

Merged
merged 65 commits into from
Jan 21, 2020
Merged

Listing block #747

merged 65 commits into from
Jan 21, 2020

Conversation

rodfersou
Copy link
Member

@rodfersou rodfersou commented May 23, 2019 •
edited
Loading

Ref.: #737

@rodfersou rodfersou marked this pull request as ready for review June 21, 2019 10:25
@pnicolli
Copy link
Contributor

pnicolli commented Jan 5, 2020

@sneridagh Looked into it. There was a bug in tests due to another merged fix (sidebar default tab), and this is fixed.
Actually, at this time, the relative path criterion isn't working, so its test is correctly failing. I tried both with the provided plone buildout as-is ('api' folder) and with the same buildout but activating the latest master for plone.rest, plone.restapi and kitconcept.voltodemo.
It needs some debugging to understand where the problem is (querystring widget or restapi), I will work more on it in the next 2 days and will post another comment here. (see #1059)

@pnicolli
Copy link
Contributor

pnicolli commented Jan 5, 2020

Found the problem with relative path and fixed it. The querystring endpoint doesn't allow calling it on a context, and there was no way of calculating the correct context for the relative path. At this time, I fixed it in the querystring action by manipulating the query in the relative path case.

@pnicolli pnicolli mentioned this pull request Jan 5, 2020
Closed
@sneridagh
Merge branch 'master' into listing-tile
eb99a8f 
* master:
  added customStyleMap param to Editor of draftjs (#1096)
  Avoid console warnings in AddFormLink.jsx (#1089)
  Back to development
  Release 4.0.0-alpha.23
  Video block mp4 support (#1103)
  Add Cypress test to test setting the effective date. (#1099)
  Added alt when selecting image in image block.
  maintain some styling when pasting (#1100)
  enable to paste links into textfields (#1093)
sneridagh and others added 3 commits January 14, 2020 19:00
@sneridagh
Merge branch 'master' into listing-tile
a1c54e8 
* master:
  Added ToC block.
@sneridagh
Merge branch 'master' into listing-tile
ebe2268 
* master:
  Back to development
  Release 4.0.0-alpha.26
  Update changelog
  German translation (#1111)
  Back to development
  Release 4.0.0-alpha.25
  Add changelog
  Generate de.json
  Add German translation for toc.
  Back to development
  Release 4.0.0-alpha.24
  Fix changelog
@pnicolli
Merge branch 'master' into listing-tile
6464be1
@pnicolli
Copy link
Contributor

@sneridagh Merged latest master and resolved newer conflicts. Do you think this is mergeable after tests? It would be awesome to start working with these in master.

@pnicolli
Copy link
Contributor

I notice there's a new error in tests after latest merge, unrelated to this block apparently. See also: #1120

@sneridagh
Copy link
Member

@pnicolli bubt then how is that the PR travis build went ok? I think this is still a heisenbug that we have around :(

@sneridagh
Copy link
Member

@pnicolli @giuliaghisini did you tried to run the tests locally? I will do now.

@sneridagh
Copy link
Member

@pnicolli @giuliaghisini green!

@pnicolli
Copy link
Contributor

@sneridagh Yes, they were green for us as well

@sneridagh sneridagh merged commit bc63d81 into master Jan 21, 2020
@sneridagh sneridagh deleted the listing-tile branch January 21, 2020 11:10
sneridagh added a commit that referenced this pull request Jan 21, 2020
@sneridagh
Merge branch 'master' into fixcollections
f177d5f 
* master:
  fix listing block customization (#1122)
  Fix remove all subjects (#1114)
  Listing block (#747)
sneridagh added a commit that referenced this pull request Jan 24, 2020
@sneridagh
Merge branch 'master' into browserlistoutdated
b017357 
* master: (29 commits)
  Back to development
  Release 4.0.0-alpha.31
  Prepare release
  fix `SelectWidget`, when there is a vocabulary and no choices (#1124)
  Back to development
  Release 4.0.0-alpha.30
  Prepare for release. Complete changelog
  Fixcollections (#1123)
  fix listing block customization (#1122)
  Fix remove all subjects (#1114)
  Listing block (#747)
  Remove internal changelog
  Revert "Pin PyYAML to fix the broken docs generation"
  Back to development
  Release 4.0.0-alpha.29
  Prepare for release
  Remove dangling reference to external data in Image block not used an… (#1118)
  Pin PyYAML to fix the broken docs generation
  Update readme
  Back to development
  ...
@sneridagh sneridagh mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneridagh sneridagh sneridagh approved these changes

Assignees

@giuliaghisini giuliaghisini

Labels
03 type: feature (plip) 04 type: enhancement 24 status: ready 32 needs: review
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@rodfersou @pnicolli @sneridagh @giuliaghisini