Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Build & slew of minor improvements #555

Merged
merged 9 commits into from
May 21, 2019
Merged

Build & slew of minor improvements #555

merged 9 commits into from
May 21, 2019

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented May 13, 2019

  • the dev build was useful before we used external source maps on the prod build -- prod and dev are now redundant as the source map is always available
  • use package-info.json in the dash_core_components/ dist folder to allow normal npm publish to work (like in table)
  • whitelisting npm publish content through files in package.json instead of blacklisting through .gitgnore / .npmignore (like in table)
  • get version information from package-info.json and package.json (setup.py) instead of version.py (like in table)
  • resolve setup.py content from package.json (like in table)
  • clean up the build commands & always build r and python components
  • removing old artefacts & dev artefacts

Tagging @rpkyle as this may impact the R generation in ways I don't understand :)

Marc-André Rivet added 3 commits May 13, 2019 14:44
- clean up `publish`
- remove redundant version.py
- remove dev build
- remove artefacts and old versions of plotlyjs
@alexcjohnson
Copy link
Collaborator

Do we use the copied package[-info].json for anything besides the version info? If so, can we just stop copying it, and instead have the component generation step create a version.py matching the package.json version?

For now since we already have this pattern in table, fine to expand it. But perhaps with dash-component-system we simplify this to an auto-generated version.py.

@Marc-Andre-Rivet
Copy link
Contributor Author

Agreed. I kept it because my understanding was that R uses it. @rpkyle?

@alexcjohnson
Copy link
Collaborator

I kept it because my understanding was that R uses it.

AFAICT R only uses the base package.json

https://github.com/plotly/dash/blob/ec1576c3652cbb90ffb064abe2753a17e13f3c51/dash/development/component_generator.py#L97-L102

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nicely done 💣

@Marc-Andre-Rivet
Copy link
Contributor Author

Marc-Andre-Rivet commented May 14, 2019

@alexcjohnson Actual back on your comment

Do we use the copied package[-info].json for anything besides the version info?

We do not, the only other usage is done with the root package.json here -- will update to generate version.py and update the table as well.

Update on will update to generate version.py and update the table as well -- this involves updating the component generator. In the end, will do this in a followup step.

Marc-André Rivet and others added 2 commits May 15, 2019 15:44
# Conflicts:
#	dash_core_components/dash_core_components.dev.js
#	dash_core_components/dash_core_components.dev.js.map
#	dash_core_components/version.py
@Marc-Andre-Rivet Marc-Andre-Rivet merged commit dc67efc into master May 21, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the improve-build branch May 21, 2019 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants