Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded plotly.js to 1.41.0 #302

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@valentijnnieman
Copy link
Contributor

commented Sep 13, 2018

This upgrades plotly.js to version 1.41.0, closes #298

@valentijnnieman valentijnnieman requested a review from chriddyp Sep 13, 2018

@valentijnnieman

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

@T4rk1n Could you check out those Percy diffs for me and see if they make sense?

@T4rk1n

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

I approved them, I think the delay before taking the first screenshot of the confirm is not enough so it's still loading.

@valentijnnieman

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

@T4rk1n Thanks!

@valentijnnieman valentijnnieman merged commit c82bea0 into master Sep 13, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by Philippe Duval
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.