Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump plotly.js to version 1.45.0 #470

Merged
merged 7 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@divyachandran-ds
Copy link
Contributor

commented Feb 28, 2019

update plotly.js version (for plotly/plotly.js#3584)
changelog to be updated.

divyachandran-ds added some commits Feb 28, 2019

Show resolved Hide resolved CHANGELOG.md Outdated
@@ -2,6 +2,13 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).


## [0.43.2] - 2019-02-28

This comment has been minimized.

Copy link
@Marc-Andre-Rivet

Marc-Andre-Rivet Mar 1, 2019

Contributor

Change this for ## [Unreleased]

@Marc-Andre-Rivet

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@divyachandran-ds Please also update contributing.md (https://github.com/plotly/dash-core-components/blob/master/CONTRIBUTING.md#updating-plotlyjs) to point to new version of plotly.js

- Orthographic 3D projections
- Hovertemplate support for more trace types, including all 3D traces
- And many other features and bug fixes
- Patch releases [1.44.4](https://github.com/plotly/plotly.js/releases/tag/v1.44.4) containing numerous bug fixes

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Mar 1, 2019

Contributor

Patch release (s)

@alexcjohnson
Copy link
Contributor

left a comment

LGTM! 💃
The percy diffs are funny - plotlyjs modebar icons show up in a different incorrect place - but at least it's over the graph now! Anyway I approved them.

divyachandran-ds and others added some commits Mar 1, 2019

@alexcjohnson alexcjohnson merged commit 361d220 into master Mar 4, 2019

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by johnson.alex.c@gmail.com
Details

@alexcjohnson alexcjohnson deleted the divya-plotlyjs-upgrade branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.