Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci path issue #429

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Fix ci path issue #429

merged 3 commits into from
Oct 18, 2018

Conversation

rmarren1
Copy link
Contributor

Fixes #419

This one was tricky to figure out.

For some reason, the Python 3 venv package behaves differently from the virtualenv package. The current working directory was not included in the PYTHONPATH and needed to be manually added back using sys.path.append. (Not sure why the dash module is available, I think this is because the new default_namespace module is created during execution rather than before).

Just getting rid of python -m venv and using virtualenv works.

Is there a good reason to be using venv rather than virtualenv?

@rmarren1 rmarren1 requested a review from T4rk1n October 18, 2018 17:04
@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 18, 2018

That venv thing was from the circleci example, but we install virtualenv anyway so we don't need it.

venv is stdlib for python >= 3.3

💃

@rmarren1 rmarren1 merged commit 9312fe4 into master Oct 18, 2018
@rmarren1 rmarren1 deleted the fix-ci-path-issue branch October 18, 2018 17:41
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants