Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for integrity and crossorigin attributes #98

Closed
rpkyle opened this issue Jun 22, 2019 · 1 comment · Fixed by #226
Closed

Add support for integrity and crossorigin attributes #98

rpkyle opened this issue Jun 22, 2019 · 1 comment · Fixed by #226
Assignees
@rpkyle
Labels
enhancement parity Modifications to improve parity across Dash implementations size: 2
Milestone
Platforms

Comments

@rpkyle
Copy link
Contributor

rpkyle commented Jun 22, 2019 •
edited
Loading

The external_scripts and external_stylesheets arguments for Dash for R currently lack support for attributes permitted in Dash for Python:

  • integrity
  • crossorigin

These should be added for parity with the Python implementation of Dash. The HTML5 specification provides for a rich set of possible attributes for <link> and <script> tags:

<link> attributes:

  • as
  • crossorigin
  • disabled
  • href
  • hreflang
  • importance
  • integrity
  • media
  • referrerpolicy
  • rel
  • sizes
  • title
  • type
  • methods
  • prefetch
  • target

<script> attributes:

  • async
  • crossorigin
  • defer
  • integrity
  • nomodule
  • nonce
  • referrerpolicy
  • src
  • type
@rpkyle rpkyle self-assigned this Jun 22, 2019
@rpkyle rpkyle mentioned this issue May 29, 2020
Closed
@rpkyle rpkyle added this to the Dash Q2/2020 milestone May 29, 2020
@rpkyle rpkyle removed this from the Dash Q2/2020 milestone Aug 16, 2020
@rpkyle rpkyle added parity Modifications to improve parity across Dash implementations size: 2 labels Aug 16, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet added this to the R & Julia milestone Aug 21, 2020
@rpkyle rpkyle mentioned this issue Aug 26, 2020
Merged
@rpkyle rpkyle linked a pull request Aug 26, 2020 that will close this issue
Provide support for script and stylesheet attributes #226
Merged
@Marc-Andre-Rivet
Copy link
Contributor

Closed by #226

@Marc-Andre-Rivet Marc-Andre-Rivet modified the milestones: R & Julia, Platforms Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpkyle rpkyle

Labels
enhancement parity Modifications to improve parity across Dash implementations size: 2
Projects
None yet
Milestone
Platforms
Development

Successfully merging a pull request may close this issue.

Provide support for script and stylesheet attributes plotly/dashR
2 participants
@Marc-Andre-Rivet @rpkyle