-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds DASH_HOST env variable #1111
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dash-renderer/package-lock.json
# Conflicts: # dash-renderer/package-lock.json
# Conflicts: # dash-renderer/package-lock.json
- update build artifacts
- update renderer artifacts - stricten dash dependencies versions
…o iframe-sandbox-support - Update build artifacts # Conflicts: # dash-renderer/src/AccessDenied.react.js # dash-renderer/src/actions/index.js # tests/integration/renderer/test_iframe.py
OwenMatsuda
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
February 5, 2020 00:07
@alexcjohnson Please review |
DashR now uses |
Should I just essentially copy the DashR change then and add PORT too? |
def run_server(
self,
host=os.getenv('HOST', "127.0.0.1"),
port=os.getenv('PORT', 8050),
...
) |
I'd guess so but will leave that decision to others :) |
OwenMatsuda
force-pushed
the
dash-host
branch
from
February 27, 2020 17:28
747ca57
to
62fa79e
Compare
Moved to #1134 because I accidentally rebased off of master instead of dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set a
DASH_HOST
environment variable to change the host value when running the server.Testing
127.0.0.1
if no environment variableapp.runserver()
, then it will take preference over the environment variable. In this case, the argument washost=127.0.0.1