Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stay aware of electron printToPDF improvements, to get rid of print background hack #12

Open
etpinard opened this issue Sep 1, 2017 · 1 comment
Open

Stay aware of electron printToPDF improvements, to get rid of print background hack #12

etpinard opened this issue Sep 1, 2017 · 1 comment

Comments

@etpinard
Copy link
Contributor

etpinard commented Sep 1, 2017

See #6 (review) and #6 (comment) for more details.
@etpinard etpinard changed the title Stay aware of electron potential printToPDF improvements, to get rid of print background hack Stay aware of electron printToPDF improvements, to get rid of print background hack Sep 5, 2017
@etpinard
Copy link
Contributor Author

etpinard commented Oct 5, 2017

Interesting. this url-to-pdf-api package has a pdf.pageRange option listed under:

https://github.com/alvarcarto/url-to-pdf-api#get-apirender

which would make setBackground from #6 hack obsolete.

@etpinard etpinard mentioned this issue May 3, 2018
Closed
@etpinard etpinard mentioned this issue Feb 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@etpinard