Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typo in plot labels for one of the examples #71

Closed
torusctyi opened this issue Oct 27, 2019 · 6 comments
Closed

[BUG] Typo in plot labels for one of the examples #71

torusctyi opened this issue Oct 27, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@torusctyi
Copy link

Description:
The plot for '1D Gaussian Distribution' has a typo. It actually reads '1D Guassian Distribution'

The image with the typo can be seen here

Fix:
The typo is caused by line 25 of the file plotters/examples/normal-dist2.rs

@torusctyi torusctyi added the bug Something isn't working label Oct 27, 2019
@torusctyi
Copy link
Author

torusctyi commented Oct 27, 2019

I'm having trouble reproducing the plot after downloading the repository to my own machine.

I got cargo build and cargo test to run fine after downloading necessary dependencies as discussed in this issue for the Servo project. (In fact, this issue was the first result I found when I googled the first error message ).

However, running cargo --example normal-dist2 produces no plot, though the code actually executes.

I then tried downloading the git repository for the documentation. As before, I was able to compile it successfully. But running cargo run --bin 2_9_vbar produced no plot as before.

@38
Copy link
Member

38 commented Oct 28, 2019

First, thanks for reporting the typo issue. I was running a type checker for the entire repo. And it fix lot more.

Also, for the normal-dist2 example, the file is produced at plotters-doc-data/normal-dist2.png
For the documentation one, it should under image/2.9.png. Just in case you didn't find it.

If the output is still missing, could you please give me some more details. Is the program crashed or panicked, any error message, etc.

Thanks!

@torusctyi
Copy link
Author

torusctyi commented Oct 28, 2019

I found the images files where you said they would be.

I assumed that a window was supposed to open with the image displayed. When nothing appeared, I thought they were being sent to /dev/null instead or something

You might save yourself a lot of time in future if you modify the code in the examples so that when an image is saved, a note is written to stderr along the lines of 'Image saved to such and such a location'. I have a feeling I won't be the last person complaining that no images are appearing otherwise lol.

Thank you very much for your help.

@38
Copy link
Member

38 commented Oct 28, 2019

Thanks for the suggestion. Just curios one more thing, do you think if putting your question to the FAQ list would help?

@torusctyi
Copy link
Author

It'd be a good idea IMHO.

@38
Copy link
Member

38 commented Nov 26, 2019

As long as we are constantly improving the documentation and seems nothing more we can actually do, closing this issue.

@38 38 closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants