Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins auth and pass config #2

Closed
tomav opened this issue Mar 7, 2016 · 3 comments
Closed

Jenkins auth and pass config #2

tomav opened this issue Mar 7, 2016 · 3 comments

Comments

@tomav
Copy link
Contributor

tomav commented Mar 7, 2016

Hi @plouc, how are you mate?

Really nice work on Mozaïk. I'm currently trying it because I need an Enterprise dashboard.
Just a question regarding the Jenkins configuration.
The README says:

{
  //… 
  api: {
    jenkins: {
      baseUrl: 'https://my-jenkins.ci',
      auth: {
        user:     'user',
        password: 'password'
      }
    }
  }
}

But I think it should be:

{
  //… 
  api: {
      jenkins: {
          baseUrl: 'https://my-jenkins.ci',
          basicAuthUser:     'user',
          basicAuthPassword: 'password'
      }
  },  
}

When I use your config, the server doesn't start and I see:

  error: jenkins.basicAuthUser: must be of type String
  jenkins.basicAuthPassword: must be of type String

Let me know, I'll be happy to PR this!

@plouc
Copy link
Owner

plouc commented Mar 9, 2016

Hi @tomav, fine, thx, I now live in Japan. And you ?

You're right about the config, feel free to make a PR ;)

@tomav
Copy link
Contributor Author

tomav commented Mar 9, 2016

#4

@plouc plouc closed this as completed Mar 9, 2016
@MPV
Copy link

MPV commented Sep 29, 2016

Maybe the same fix should be done in the mozaik-demo too?
https://github.com/plouc/mozaik-demo/blob/master/config.js#L27-L30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants