Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget is using deprecated getApiRequest id #2

Closed
juhamust opened this issue Feb 27, 2015 · 2 comments
Closed

Widget is using deprecated getApiRequest id #2

juhamust opened this issue Feb 27, 2015 · 2 comments

Comments

@juhamust
Copy link
Contributor

Recent change in Mozaik deprecates the usage of �unique ids, like https://github.com/plouc/mozaik-ext-weather/blob/master/src/components/Weather.jsx#L67

Error: Invalid request id "weather.combined.Helsinki.FI.en.2", should be something like 'api_id.method'
    at Bus.clientSubscription (/app/node_modules/mozaik/lib/Bus.js:92:27)

Earlier, however, the same data was returned if the id did not change while params did.

@juhamust
Copy link
Contributor Author

Confirmed. It seems the extension/client API is only called once - even if the params do change.

@plouc
Copy link
Owner

plouc commented Feb 27, 2015

Fixed in plouc/mozaik@f4bffb1, the old format is the with api_id.method.unique_param is the good one

@plouc plouc closed this as completed Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants