Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalendarCanvas's tooltip broke in v0.80.0 #2122

Closed
nekochan0122 opened this issue Sep 10, 2022 · 5 comments · Fixed by #2125
Closed

CalendarCanvas's tooltip broke in v0.80.0 #2122

nekochan0122 opened this issue Sep 10, 2022 · 5 comments · Fixed by #2125
Assignees
@plouc
Labels
bug 🖼️ canvas

Comments

@nekochan0122
Copy link

nekochan0122 commented Sep 10, 2022 •
edited
Loading

To Reproduce
https://nivo.rocks/storybook/?path=/story/calendarcanvas--custom-tooltip
https://codesandbox.io/s/calendarcanvass-tooltip-broke-in-v0-80-0-7dcb3q?file=/src/App.tsx

Screenshots
image

Desktop:

  • OS: Windows
  • Browser Edge
  • Version 105.0.1343.27
@nekochan0122
Copy link
Author

I tested other canvas charts on nivo.rocks/storybook, They also broke 🥲

@plouc plouc self-assigned this Sep 10, 2022
@plouc
Copy link
Owner

plouc commented Sep 10, 2022

It seems to be related to this fix, it uses getBBox which isn't available for canvas elements.

@plouc plouc mentioned this issue Sep 11, 2022
Closed
@plouc plouc linked a pull request Sep 11, 2022 that will close this issue
fix(canvas): fix getRelativeCursor for non SVG implementations #2125
Merged
@plouc plouc mentioned this issue Sep 11, 2022
Merged
@nekochan0122
Copy link
Author

nekochan0122 commented Sep 11, 2022 •
edited
Loading

It seems to be related to this fix, it uses getBBox which isn't available for canvas elements.

Thx for the reply, I'll keep following the PR and test it ❤️
Beautiful charts by the way.

@yannbolliger
Copy link

Hi there, when will this fix be released, is there already a date?

@shehi shehi mentioned this issue Oct 15, 2022
Closed
@sighrobot
Copy link

You may be interested in the temporary shim approach described in #2162 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plouc plouc

Labels
bug 🖼️ canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(canvas): fix getRelativeCursor for non SVG implementations plouc/nivo
4 participants
@plouc @sighrobot @yannbolliger @nekochan0122