Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips are not consistent for all components #745

Closed
taschetto opened this issue Nov 12, 2019 · 6 comments
Closed

Tooltips are not consistent for all components #745

taschetto opened this issue Nov 12, 2019 · 6 comments
Labels

Comments

@taschetto
Copy link

Is your feature request related to a problem? Please describe.
It is not possible to render a custom tooltip within a Calendar day without wrapping it with a BasicTooltip (https://github.com/plouc/nivo/blob/master/packages/calendar/src/CalendarDay.js#L92-L104).

Describe the solution you'd like
We should be able to use a custom component alone, without the need to wrap it with a BasicTooltip, just like the Line/Mesh tooltip (https://github.com/plouc/nivo/blob/master/packages/line/src/Mesh.js#L43-L47).

Describe alternatives you've considered
I haven't found an alternative.

Additional context

Custom tooltip being used with line charts
Custom tooltip being used with line charts

The same tooltip being used with calendars, wrapped inside a BasicTooltip
The same tooltip being used with calendars, wrapped inside a BasicTooltip

@plouc
Copy link
Owner

plouc commented Nov 27, 2019

That's also the case for scatterplot, see #754

@plouc plouc changed the title Allow to render tooltip within a Calendar without wrapping it inside a BasicTooltip Tooltips are not consistent for all components Nov 27, 2019
@plouc
Copy link
Owner

plouc commented Nov 27, 2019

@taschetto I took the liberty to rename this issue instead of having one for each component type behaving differently.

@stale
Copy link

stale bot commented Oct 29, 2020

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Oct 29, 2020
@ianstormtaylor
Copy link

@plouc I think this same issue affected the <ResponsiveTreemap>? I'd like to have the same tooltip behavior from line charts to have complete control over the rendering, but it's getting wrapped in an extra box.

@stale stale bot removed the stale label Oct 31, 2020
@stale
Copy link

stale bot commented Jan 29, 2021

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jan 29, 2021
@stale
Copy link

stale bot commented Feb 5, 2021

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants