Add changes to allow for improved accessibility on charts. #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plouc This would be very helpful for improving the accessibility of the charts. Would it be possible to take a look? |
|
@plouc Any update on this? Our company is hoping to continue using Nivo but we depend on this enhancement. |
|
bump |
|
Hi, sorry for the late reply, I'll try to have a look at this PR over
the next few days.
Le ven. 14 août 2020 à 06:11, Peter Hrynkow <notifications@github.com> a
écrit :
… bump
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1054 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD2PCWJA33HKCOZL4H7TGTSARJH7ANCNFSM4OY4GC6Q>
.
|
|
@erik-1234, thank you for your contribution! |
7 tasks
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for improved a11y on the charts that use the
<SvgWrapper>component.Currently,
<SvgWrapper>has the default role on the tag set torole="img". This makes the chart inaccessible to screen readers. Adding a role prop to the<Bar>component, and passing through to<SvgWrapper>allows for accessibility by optionally setting the role togroup.There's also the addition of the
ariaHiddenprop to theAxiscomponent. When this value is set totrueand the chart is accessible, it will allow the user to skip over the values of the axes when using a screen reader which can improve the user experience.