Initial import from go-libp2p-kad-dht #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test query interactions with routing table * v2: upgrade to go1.21 * Add uci config * Use newer uci actions * Pass clock to coordinator * Use v2 working directory in actions * Set go-version input in actions * Set go-version input in actions * Use go 1.20.8 in actions * Use go 1.21.1 and relative working directory * Try default working directory on job * Remove uci.yaml which is not supported yet * Try default working directory on job * Try default working directory as input * Restore uci.yaml * Restore uci.yaml * Use modified go-check * Use modified go-test * Fix go-test * Fix go-test * Fix go-test * Update go-kademlia * Add more tracing * Use go-kademlia trie fix
This PR changes tracing to use the OpenTelemetry protocol which is also recommended by Jaeger. [`go.opentelemetry.io/otel/exporters/jaeger`](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/jaeger): > Deprecated: This module is no longer supported. OpenTelemetry dropped support for Jaeger exporter in July 2023. Jaeger officially accepts and recommends using OTLP. Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp) or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc) instead. Works with the following docker command: ```go docker run --rm --name jaeger -p 16686:16686 -p 4317:4317 jaegertracing/all-in-one:1.49 ``` Note that `jaegertracing/all-in-one` version `1.49` is **newer** than version `1.6` which we often used in the past (5 years old).
* Decouple coord package from addressing * Go fmt * fix: garbage collection test race condition (#904) Moved ticker initialization outside the garbage collection goroutine. There was a race condition between advancing the mocked time in TestProvidersBackend_GarbageCollection and the initialization of the ticker that triggers the garbage collection runs. It happened that we were advancing the time without the ticker being initialized. Hence, advancing the time hasn't had any effect. In this PR, I moved the ticker initialization outside the garbage collection goroutine. This means the ticker will be registered with the MockClock object after StartGarbageCollection returns. Calls to mockClock.Add will therefore trigger the ticker. * Fix test flakes that wait for routing events (#905) * Increase test iterations to trigger flake * Add failfast * Replace routing notification channel with a RoutingNotifier type * Remove unused code * Remove test count --------- Co-authored-by: Dennis Trautwein <git@dtrautwein.eu>
* Implement GetValue * Add failing TestGetValueOnePeer test * Unexport methods
* Improve query capabilities * go mod tidy * Review feedback * go mod tidy * Move coord packages to internal (#933) * Move coord and kadt packages to internal * go mod tidy * go fmt * Move kadt out of internal and add RoutingTable interface
Co-authored-by: Ian Davis <18375+iand@users.noreply.github.com>
* Improve query capabilities * go mod tidy * Review feedback * go mod tidy * Move coord packages to internal (#933) * Move coord and kadt packages to internal * go mod tidy * go fmt * Move kadt out of internal and add RoutingTable interface * Add explore state machine to expand population of routing table * Refactor schedule into separate type * Add generation of random peer id for a given cpl * go mod tidy * Add prefixmap generator * Use constants for various query ids * go mod tidy * Wire explore state machine into routing behaviour * Remove some unnecessary conversions * PR review updates
* Expose behaviour and state machine configs * Adjust test * Revert adjust test
* feat: findProvidersAsync * add: find providers tests * add config tests
* Add metrics to routing state machines * Simplify use of gauges with atomics
* Loggiing improvements * Add more debug logging * Add more debug logging * Use logging helpers
iand
force-pushed
the
initial-import
branch
from
4bd1c39
to
083e0c6
Compare
guillaumemichel
approved these changes
Oct 2, 2023
dennis-tra
approved these changes
Oct 2, 2023
| @@ -0,0 +1 @@ | |||
| github.com | |||
There was a problem hiding this comment.
just curious where this comes from - As a gitignore basis I tend to use https://www.toptal.com/developers/gitignore/
There was a problem hiding this comment.
I'm not sure why this particular value is there. It came from this commit libp2p/go-libp2p-kad-dht@54f20b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of libp2p/go-libp2p-kad-dht#954
Remember to use "rebase and merge" for this pr