split escaping and translating #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
pushed a commit
that referenced
this pull request
Feb 10, 2017
* a little bit brighter * a little bit brighter * Update styles.css * Update styles.min.css * select[multiple] adjustment * select[multiple] adjustment * Update styles.css * Update styles.min.css * Update styles.css * Update styles.min.css * Update styles.css * Update styles.css * Update styles.min.css * Update styles.css * Update styles.min.css * Update styles.css * Update styles.min.css * some cleanup * some cleanup * Update styles.css * Update styles.css * Update styles.min.css * Update styles.css * Update styles.min.css * Update styles.min.css * Update styles.css * Update styles.min.css * make spam reasons translateable * rename regexp to regular expression * Fixed last lable issues Labels and <select> elements are friends again. fixes #114 Minor CSS changes have been reverted to ensure consisten behaviour across viewports and devices. * add the .travis.yml (#118) * add the .travis.yml * uncomment 5.2 - 5.4, remove hhvm, uncomment nightly * split escaping and translating (#112) * some cleaning (#113) * use a more generic term for DNSBL * add __() stub for tests * make spam reasons translateable * rename regexp to regular expression * use a more generic term for DNSBL * add __() stub for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #81
To solve the problem, I consequently did split up the escaping from the translating. The translation now does not use
esc_html__()no more but__().During the printing process, instead of trying to translate the variable with
esc_html__()we just make sure the variable gets escaped.