Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#138 duplicated content #147

Merged
merged 22 commits into from
Aug 3, 2024
Merged

#138 duplicated content #147

merged 22 commits into from
Aug 3, 2024

Conversation

MSACC
Copy link
Collaborator

@MSACC MSACC commented May 20, 2024

What does it do?

Added decorators for deleteMany and cloning.

Why is it needed?

When cloning, url-alias should not be cloned, but getting another url
When deleteMany, it should delete all the url-aliases from the database

How to test it?

Check if clone works as expected
Check if deleteMany works as expected

Related issue(s)/PR(s)

#138

Copy link

changeset-bot bot commented May 20, 2024

⚠️ No Changeset found

Latest commit: a15f259

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MSACC MSACC requested a review from boazpoolman May 20, 2024 16:55
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.09%. Comparing base (f0ef406) to head (645e112).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #147       +/-   ##
===========================================
+ Coverage    0.96%   30.09%   +29.13%     
===========================================
  Files         189        4      -185     
  Lines        2907    14010    +11103     
  Branches      396     4977     +4581     
===========================================
+ Hits           28     4217     +4189     
- Misses       2707     7759     +5052     
- Partials      172     2034     +1862     
Flag Coverage Δ
unit 30.09% <ø> (+29.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSACC MSACC requested a review from boazpoolman May 27, 2024 19:50
Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deleteMany decorator works great! Good work 👍

Sadly I still see an issue with the clone decorator. I've added a screen recording in which you can see that upon duplication I have the ability to change some of the values before continuing. If I change for example the title and I hit save the updated title field is not respected.

Schermopname.2024-05-27.om.22.38.48.mov

@boazpoolman boazpoolman merged commit f261183 into master Aug 3, 2024
4 checks passed
@boazpoolman boazpoolman deleted the #138-Duplicated-Content branch August 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants