-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#138 duplicated content #147
Conversation
|
packages/core/server/admin-api/services/query-layer-decorator.ts
Outdated
Show resolved
Hide resolved
packages/core/server/admin-api/services/query-layer-decorator.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
===========================================
+ Coverage 0.96% 30.09% +29.13%
===========================================
Files 189 4 -185
Lines 2907 14010 +11103
Branches 396 4977 +4581
===========================================
+ Hits 28 4217 +4189
- Misses 2707 7759 +5052
- Partials 172 2034 +1862
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleteMany decorator works great! Good work 👍
Sadly I still see an issue with the clone decorator. I've added a screen recording in which you can see that upon duplication I have the ability to change some of the values before continuing. If I change for example the title and I hit save the updated title field is not respected.
What does it do?
Added decorators for deleteMany and cloning.
Why is it needed?
When cloning, url-alias should not be cloned, but getting another url
When deleteMany, it should delete all the url-aliases from the database
How to test it?
Check if clone works as expected
Check if deleteMany works as expected
Related issue(s)/PR(s)
#138