Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexibility: temporary core util for refactoring to vanilla css #1689

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

EdwardIrby
Copy link
Contributor

@EdwardIrby EdwardIrby commented Mar 24, 2021

resolves #1685

usage

Normal core var import

import {
  layout,
  type,
  motion,
  colorsTextIcon,
  colorsGreen,
  colorsBackgroundDark,
  colorsBorder,
  colorsBackgroundUtility
} from '@pluralsight/ps-design-system-core'

Refactored

import { refactorCssVars} from '@pluralsight/ps-design-system-core'
const {
  layout,
  type,
  motion,
  colorsTextIcon,
  colorsGreen,
  colorsBackgroundDark,
  colorsBorder,
  colorsBackgroundUtility
} = refactorCssVars

We then run a build and now have a css file in our dist directory with the correctly formatted css custom properties and ready for use to do some refactoring on

@EdwardIrby EdwardIrby linked an issue Mar 29, 2021 that may be closed by this pull request
@EdwardIrby EdwardIrby linked an issue Mar 29, 2021 that may be closed by this pull request
@EdwardIrby EdwardIrby marked this pull request as ready for review March 29, 2021 21:42
@EdwardIrby EdwardIrby changed the title feat(core): temp core util for refactoring to vanillia css flexibility: temporary core util for refactoring to vanilla css Mar 30, 2021
@EdwardIrby EdwardIrby merged commit f8485da into master Apr 1, 2021
@EdwardIrby EdwardIrby deleted the experiment/refactorCSSVars-flexibility branch April 1, 2021 23:35
jaketrent added a commit that referenced this pull request Apr 7, 2021
* master:
  build: publish
  fix(datepicker): closes on click outside resolves #1655 (#1700)
  tagsinput: fix scroll bar position when items/pills overflow  (#1702)
  flexibility: remove base from color scale & add parseToRgb (#1696)
  fix(searchinput): weird type bug resolved (#1698)
  feat(core): temp core util for refactoring to vanillia css (#1689)
  build: publish
  select: stop intercepting all key events (#1699)
  build: publish
  fix(storybook-addon-theme): update incorrect package name in README
  feat(storybook-addon-theme): update icon to circle
  feat(storybook-addon-theme): ability to set theme per-story
  util: polymorphic primatives (#1690)
  build: publish
  fix(select): dropdown zindex added (#1691)
  Update @pluralsight/ps-design-system-storybook-addon-theme package.json for addon-catalog
  Update @pluralsight/ps-design-system-storybook-addon-center package.json for addon-catalog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flexibility: temporary cssVars utility flexibility: update color vars
2 participants