flexibility: remove base from color scale & add parseToRgb #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: update color.base usages to color[6]
EdwardIrby
requested review from
jaketrent and
sweeting
and removed request for
jaketrent
BREAKING CHANGE: switch colorsBackgroundUtility.base usage to
EdwardIrby
force-pushed
the
refactor/colorVars
branch
from
07910be
to
2ddbcfa
Compare
EdwardIrby
changed the title
jaketrent
reviewed
Mar 31, 2021
packages/core/src/js/colors.ts
Outdated
| @@ -147,7 +138,7 @@ export const colorsBackgroundLight = { | |||
| } | |||
|
|
|||
| export const colorsBackgroundUtility = { | |||
| base: '#8A99A8', | |||
| base: '138,153,168', | |||
There was a problem hiding this comment.
Having some values rgba()-wrapped and some with raw csv will lead to unpredictable usage of these values. I would rather do them all at once and cut over. It's already a breaking change.
What do you think?
There was a problem hiding this comment.
This is the only color we really need these raw values for. because of how often we combine it with transparentize. The other colors are more one offs.
jaketrent
approved these changes
Mar 31, 2021
…stem into refactor/colorVars
jaketrent
added a commit
that referenced
this pull request
Apr 7, 2021
* master: build: publish fix(datepicker): closes on click outside resolves #1655 (#1700) tagsinput: fix scroll bar position when items/pills overflow (#1702) flexibility: remove base from color scale & add parseToRgb (#1696) fix(searchinput): weird type bug resolved (#1698) feat(core): temp core util for refactoring to vanillia css (#1689) build: publish select: stop intercepting all key events (#1699) build: publish fix(storybook-addon-theme): update incorrect package name in README feat(storybook-addon-theme): update icon to circle feat(storybook-addon-theme): ability to set theme per-story util: polymorphic primatives (#1690) build: publish fix(select): dropdown zindex added (#1691) Update @pluralsight/ps-design-system-storybook-addon-theme package.json for addon-catalog Update @pluralsight/ps-design-system-storybook-addon-center package.json for addon-catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes base from color scale based on conversation with @sweeting
Adds new
parseToRgb()to make refactoring transparentize usage easier.resolves #1684