fix(searchinput): weird type bug resolved #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaketrent
approved these changes
Apr 1, 2021
jaketrent
added a commit
that referenced
this pull request
Apr 7, 2021
* master: build: publish fix(datepicker): closes on click outside resolves #1655 (#1700) tagsinput: fix scroll bar position when items/pills overflow (#1702) flexibility: remove base from color scale & add parseToRgb (#1696) fix(searchinput): weird type bug resolved (#1698) feat(core): temp core util for refactoring to vanillia css (#1689) build: publish select: stop intercepting all key events (#1699) build: publish fix(storybook-addon-theme): update incorrect package name in README feat(storybook-addon-theme): update icon to circle feat(storybook-addon-theme): ability to set theme per-story util: polymorphic primatives (#1690) build: publish fix(select): dropdown zindex added (#1691) Update @pluralsight/ps-design-system-storybook-addon-theme package.json for addon-catalog Update @pluralsight/ps-design-system-storybook-addon-center package.json for addon-catalog
Closed
EdwardIrby
commented
Jun 9, 2021
Comment on lines
-21
to
+23
| export interface SearchInputProps | ||
| extends React.ComponentProps<typeof TextInput> { | ||
| export interface SearchInputProps extends TextInputProps { |
There was a problem hiding this comment.
@jaketrent this the example I'm talking about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was a weird one. I ended up playing with it until I got the build to output something more inline with that TextInput was outputting as it was doing a weird extension of it. Should resolve the issue I hope.
Resolves: #1683