Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix bug in handling of failed github authentication request
- The error scenario from the flask.oauthlib.authorized_response() doesn't return None. It can return an Exception object as well. So, checking for None is not very effective. - This fixes the limited issue we've seen in production related to the return from the oauthlib not having the `access_token` in it. This bug was leading to a `KeyError` and masking the real reason github didn't return us the token.
- Loading branch information