Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show contributors #45

Merged
merged 6 commits into from
Apr 14, 2016
Merged

Show contributors #45

merged 6 commits into from
Apr 14, 2016

Commits on Apr 14, 2016

  1. Change cursor while sending ajax request to help indicate something i… 

    …s happening
    @durden
    durden committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    a1420a0 View commit details
    Browse the repository at this point in the history

  2. Add listing of contributors to bottom of guide 

    - This uses the github commits API.  A guide 'contributor' is classified as
  someone other than the original author that shows up in the commits as an
  'author' i.e. they've contributed at least 1 line to the guide itself.
- Note this doesn't handle pagination for the commit API yet so the
  contributors list only reflects data from the most recent 30 commits to a
  guide.
- Related to #34
    @durden
    durden committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    f5290ec View commit details
    Browse the repository at this point in the history

  3. Remove redundant contributors in favor of listings with full names 

    - The commit history can include an author multiple times.  Sometimes that
  history can have the author's full name and login and other times it can only
  include login.  This change makes sure we don't ever count a user as a
  contributor more than once regardless of whether there were commits with and
  without their real name.
- Also changed contributors property to return a list of tuples instead of a
  list of User objects, which will make it easy to serialize and cache.
    @durden
    durden committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    5a64f28 View commit details
    Browse the repository at this point in the history

  4. Cache contributors for published articles when reading their rendered… 

    … text

- This effectively makes sure we cache the guide with the list of contributors
  when showing published guide pages.
    @durden
    durden committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    548004e View commit details
    Browse the repository at this point in the history

  5. Do not put contributors in metadata 

    - The metadata is meant as peristent storage for things that do not change very
  often.  The list of contributors can change often and that information is
  already persistent in the commit history.
    @durden
    durden committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    8dc517b View commit details
    Browse the repository at this point in the history

  6. Add edit link under list of contributors for a guide

    @durden
    durden committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    1544d13 View commit details
    Browse the repository at this point in the history