Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design improvements #87

Merged
merged 6 commits into from Jun 9, 2016
Merged

Design improvements #87

merged 6 commits into from Jun 9, 2016

Conversation

paulocheque
Copy link
Contributor

@paulocheque paulocheque commented Jun 2, 2016

  • White logo
  • Navbar link alignment
  • Buttons flat
  • editor buttons colors

@paulocheque
Copy link
Contributor Author

Check some of the images:

screen shot 2016-06-02 at 3 30 45 pm
screen shot 2016-06-02 at 3 30 56 pm
screen shot 2016-06-02 at 3 31 03 pm
screen shot 2016-06-02 at 3 31 12 pm
screen shot 2016-06-02 at 3 31 18 pm

@paulocheque
Copy link
Contributor Author

screen shot 2016-06-02 at 4 47 22 pm

@durden
Copy link
Contributor

durden commented Jun 7, 2016

@edroman and @prtkgpt Any thoughts on this hack.guides logo above with 'by pluralsight'?

@prtkgpt
Copy link
Contributor

prtkgpt commented Jun 8, 2016

screen shot 2016-06-08 at 10 53 27 am

I think we can do "by Pluralsight" like in the hackhands logo, hackhands.com

Any thoughts @edroman

@edroman
Copy link
Contributor

edroman commented Jun 8, 2016

Sure, either way is fine.

On Wed, Jun 8, 2016 10:54 AM, Prateek Gupta notifications@github.com wrote:

I think we can do "by Pluralsight" like in the hackhands logo, hackhands.com


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub , or mute the thread .

Ed Roman 415-583-3815
http://about.me/Edro
Follow me on AngelList: http://angel.co/Edro

@prtkgpt
Copy link
Contributor

prtkgpt commented Jun 8, 2016

beta

@paulocheque let's move forward with "by pluralsight" in bottom of hack.guides() logo.

@paulocheque
Copy link
Contributor Author

ok!

ps: with a unique image we will lost the link for the Pluralsight site. But I don't think this is a big deal since we can put the link in another place.

@paulocheque
Copy link
Contributor Author

@prtkgpt Could you send this image with transparent background?

@prtkgpt
Copy link
Contributor

prtkgpt commented Jun 9, 2016

@paulocheque I used canva.com to add BETA and PLURALSIGHT (both in white) and dark ground.

It's the same logo you sent on Slack

@paulocheque
Copy link
Contributor Author

ok! thanks!

Follow the changes.

screen shot 2016-06-09 at 11 57 00 am
screen shot 2016-06-09 at 11 57 10 am

@prtkgpt prtkgpt merged commit 465e49b into pluralsight:master Jun 9, 2016
@durden
Copy link
Contributor

durden commented Jun 9, 2016

Was this tested on a real site before merging or did you confirm only the
screenshots? Merging the cms code itself should be done with more care than
the tutorials. I usually test the branch myself locally and on a test site
before merging. I'll publish this to production once I test it locally.

On Thursday, June 9, 2016, Prateek Gupta notifications@github.com wrote:

Merged #87 #87.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#87 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AADizw1eqPt1p-YKVr_VAjdbQ2FRaDJPks5qKGTzgaJpZM4Is3Mn
.

@durden
Copy link
Contributor

durden commented Jun 13, 2016

Is it just me or is the word 'guides' in the logo fuzzy? It's not as crisp as the words 'summit' and 'pledge' in the other logos. Scroll over the hack.guides logo to see the difference. I've pushed this code to the staging site for reference so you can see a live example of the results.

@paulocheque Can you sharpen up that text?

@durden
Copy link
Contributor

durden commented Jun 13, 2016

Also, I prefer the old button colors for the editor. However, I don't mind the new buttons so we can change them if everyone agrees. What do you guys think @prtkgpt @edroman?

The old buttons:

screenshot 2016-06-13 08 02 51

The new buttons:

8f69cba6-28d9-11e6-807f-837bc19e53bf

@durden
Copy link
Contributor

durden commented Jun 13, 2016

The logo resolution also looks fuzzy on the article pages. Should we remove the orange from the word 'guides' and use the same grey used in the word 'hack' for the article pages?

@edroman
Copy link
Contributor

edroman commented Jun 13, 2016

Yes, good observation.

On Monday, June 13, 2016, Luke Lee notifications@github.com wrote:

The logo resolution also looks fuzzy on the article pages
http://pskb-stage.herokuapp.com/python/faster-single-column-slicing-with-dataframes.
Should we remove the orange from the word 'guides' and use the same grey
used in the word 'hack' for the article pages?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#87 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABMLzQ90q_w9VSZ6wax-O4EZURFEMz-Hks5qLTPIgaJpZM4Is3Mn
.

Ed Roman
415-583-3815
http://about.me/Edro
Follow me on AngelList: http://angel.co/Edro

@paulocheque
Copy link
Contributor Author

Maybe it is my monitor/resolution I am not able to see that. Could you take a screenshot for me?

I can revert the colors. I have just done that because the blue color has not been used in another part of the system and it is different of orange kind. And the red button is more attractive than the save button. But I am not a designer, so I know I am not good at it ;)

@durden
Copy link
Contributor

durden commented Jun 13, 2016

Here's screenshots of the logos. Hopefully the fuzziness shows up for you. The 'white' logo with the orange 'guides' word seems to be worse but that could just be because it's set on a white background:

screenshot 2016-06-13 20 24 39

screenshot 2016-06-13 20 24 50

@durden
Copy link
Contributor

durden commented Jun 13, 2016

I'm not completely OK with the blue color of the 'options' button so we could change that to another color. I just wanted to use a 'friendly' color that indicates it's OK to click that button. The back button is red because that is a color that signals 'think before you click this'.

@durden
Copy link
Contributor

durden commented Jun 14, 2016

@paulocheque See @prtkgpt comment's on changing the 'white' logo. The net change is making the text darker and look like the summit and pledge logos on the article pages.

@durden
Copy link
Contributor

durden commented Jun 14, 2016

To summarize, here's what I think we need to finish up this request:

  1. Revert editor button color changes
    • Again, we can pick a different color for the 'Options' button if you have any suggestions.
  2. Cleanup logo used on the black background.
    • The word 'guides' is still a bit fuzzy to me. Maybe we can fix it by just making the font a bit thicker while still keeping the word 'hack' a bit thicker than 'guides'.
  3. Cleanup logo used on white background
    • Change 'hack' word to be dark black and 'guides' to be a lighter shade of black, similar to the summit and pledge logos on the article pages.

I can reach out to our in-house designer for these logo changes if needed. The only downside there is he is pretty busy and can't turn things around quite as fast as we can, but let me know if that's something we need to do.

@paulocheque
Copy link
Contributor Author

paulocheque commented Jun 14, 2016

I made these updates, please check in the dev site if it is better now.

@durden
Copy link
Contributor

durden commented Jun 15, 2016

Thanks. The new logos look awesome!

We're going to have a confusing merge because Prateek merged this PR before it was done. So, I'm going to revert that merge for now. Can you separate the design changes from the "expert" feature and push only the design changes to this branch/PR?

So, we'll end up with a commit history like this:

  • Merged partial design changes
  • Reverted partial design changes
  • Merged final design changes

@durden
Copy link
Contributor

durden commented Jun 15, 2016

I'm not sure how github will handle pushing changes to a PR that's already been merged. So, to avoid that possible confusion lets do this:

  1. Separate out new design changes into clean commits
  2. Create a new PR for those changes only
    • Make sure to reference this PR when committing or creating the new PR so we can a link between them for historical context
  3. Then, I can merge those changes as a separate PR.

@paulocheque
Copy link
Contributor Author

ok, I will create a new PR for that!

paulocheque added a commit to paulocheque/guides-cms that referenced this pull request Jun 15, 2016
This is branch is the same of the pluralsight#87 PR, without changing the colors of the editor buttons.
@paulocheque
Copy link
Contributor Author

#94

durden added a commit that referenced this pull request Jun 16, 2016
Design improvements (Related to PR #87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants