New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design improvements #87
Conversation
paulocheque
commented
Jun 2, 2016
•
edited
edited
- White logo
- Navbar link alignment
- Buttons flat
- editor buttons colors
I think we can do "by Pluralsight" like in the hackhands logo, hackhands.com Any thoughts @edroman |
Sure, either way is fine. On Wed, Jun 8, 2016 10:54 AM, Prateek Gupta notifications@github.com wrote: I think we can do "by Pluralsight" like in the hackhands logo, hackhands.com — Ed Roman 415-583-3815 |
@paulocheque let's move forward with "by pluralsight" in bottom of hack.guides() logo. |
ok! ps: with a unique image we will lost the link for the Pluralsight site. But I don't think this is a big deal since we can put the link in another place. |
@prtkgpt Could you send this image with transparent background? |
@paulocheque I used canva.com to add BETA and PLURALSIGHT (both in white) and dark ground. It's the same logo you sent on Slack |
Was this tested on a real site before merging or did you confirm only the On Thursday, June 9, 2016, Prateek Gupta notifications@github.com wrote:
|
Is it just me or is the word 'guides' in the logo fuzzy? It's not as crisp as the words 'summit' and 'pledge' in the other logos. Scroll over the hack.guides logo to see the difference. I've pushed this code to the staging site for reference so you can see a live example of the results. @paulocheque Can you sharpen up that text? |
The logo resolution also looks fuzzy on the article pages. Should we remove the orange from the word 'guides' and use the same grey used in the word 'hack' for the article pages? |
Yes, good observation. On Monday, June 13, 2016, Luke Lee notifications@github.com wrote:
Ed Roman |
Maybe it is my monitor/resolution I am not able to see that. Could you take a screenshot for me? I can revert the colors. I have just done that because the blue color has not been used in another part of the system and it is different of orange kind. And the red button is more attractive than the save button. But I am not a designer, so I know I am not good at it ;) |
I'm not completely OK with the blue color of the 'options' button so we could change that to another color. I just wanted to use a 'friendly' color that indicates it's OK to click that button. The back button is red because that is a color that signals 'think before you click this'. |
@paulocheque See @prtkgpt comment's on changing the 'white' logo. The net change is making the text darker and look like the summit and pledge logos on the article pages. |
To summarize, here's what I think we need to finish up this request:
I can reach out to our in-house designer for these logo changes if needed. The only downside there is he is pretty busy and can't turn things around quite as fast as we can, but let me know if that's something we need to do. |
I made these updates, please check in the dev site if it is better now. |
Thanks. The new logos look awesome! We're going to have a confusing merge because Prateek merged this PR before it was done. So, I'm going to revert that merge for now. Can you separate the design changes from the "expert" feature and push only the design changes to this branch/PR? So, we'll end up with a commit history like this:
|
I'm not sure how github will handle pushing changes to a PR that's already been merged. So, to avoid that possible confusion lets do this:
|
ok, I will create a new PR for that! |
This is branch is the same of the pluralsight#87 PR, without changing the colors of the editor buttons.
Design improvements (Related to PR #87)