Open graph tags #95
Merged
Open graph tags #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on FB - Also add og:image tag to guide pages so the stack icon shows up if it's available. - Note FB open graph tags require external URLs
…ide pages
- Add explicit width/height and description to satisfy open graph debugger warnings
- This will fallback to the user's avatar image if the stack image isn't the
right format.
- We're planning on transitioning to png for stack images so this should
automatically work once that change happens.
- Follow #89 for more discussion on that topic.
|
This change adds the open graph meta tags to every page of the site for easier sharing. All pages except the guide pages will use the hack.guides() logo and generic site description. The guide pages will use a description like 'Guide related to ', the stack image if it's png/jpg/jpeg (see #89 for more info), and the guide title. For reference, this improvement was first suggested by Rishi Athanikar in this tweet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.