-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests and deprecations on Julia v0.6 #230
Conversation
Thank you very much!! It seems some of the unit tests on Travis CI is breaking. Could you have a look? |
Sure! My most recent commit should fix v0.5 support. The test errors on v0.6 will be fixed with: kmsquire/Logging.jl#54 and I've updated the |
Hmm, the Julia v0.5 tests are stalling out. I'm not sure what's going on there. On the other hand, the v0.6 tests are running much faster than before. Could this be due to the randomness inside the test functions? Would you consider fixing the random number seed to get more consistent test behavior? |
The Travis build on v0.5 is consistently getting stuck here:
perhaps it's using enough memory to force the Travis VM to swap and thrash? |
Yes Pooling with 6D inputs takes a bit longer to run. Let's wait a bit since the nightly test has already passed. It should be ready to be merged once the 0.5 test pasts! |
How do you want to handle the changes to Logging.jl? I don't know how long it will take for that PR to be merged. |
It might be possible to replacing the use of Logging.jl with the new built-in logging capabilities in Julia v0.6: JuliaLang/julia#16213 |
Yes, it is a bit tricky. We can merge this PR first and then either try to push the Logging PR to be merged or as you mentioned, try to use the built-in logging capability. Do you know when is the planned release for Julia v0.6? |
Soon, hopefully :) By the way, one reason that the v0.5 tests are so slow could be the coverage tracking. @tkoolen and I have noticed that running tests with |
This PR fixes all of the unit tests on Julia v0.6 (as of today's release-0.6 branch). It also fixes all of the outstanding deprecation warnings
except for a few relating toproduce()
andconsume()
which I don't understand well enough to fix yet.Notable changes:
NullBlob <: Blob
toNullBlob <: Blob{Void, 0}
. Please let me know if that's not correct.abs(::Vector)
changed toabs.(::Vector)
abs(rand(Int, N)) % Y + X
changed torand(X:(X + Y - 1), N)
to avoid a deprecation and make the function easier to understandArray(T, size...)
changed toArray{T}(size...)
abstract Foo
changed toabstract type Foo end
(with a@compat
annotation for 0.5)produce()
andconsume()
to use channels on v0.6. This is not something I have much experience with, but I think I got it rightThis does not fix: