Show past events of specific color(s)

[yvolk]

As I wrote in #126 "Add a notion of "completed" Calendar event", I'm searching for a way to see past events, which require my attention. E.g. events, which are not "Completed", not "done" or something...
As these things ("notions") are not natural to Android calendars (including Google Calendar app), adding them only to a Widget will be a partial solution. So I decided that we may achieve the same results using simple Google/Android means: colors.
Any User may use colors as they wish, so this addition of (optional) specific treatment of event color may be very popular because it's universal. I guess Google designers thought similar, when they limited classification of items in Google Calendar, Keep etc. to several colors only (see e.g. https://support.google.com/calendar/answer/1248865?hl=en )

As a first step (and maybe, as the last also...) I propose to add this option:

Preference Screen: "Past events" (as a group of similar options, #122 - "Events that ended in past X hours", will be included here also)
One "ListPreference":
Title: "Show past events with color"
And three entries: "(this option is turned off)", "The same as default calendar color", "Other than default calendar color".

[yvolk]

I implemented the change, please see the commit 8dc6db9 above.
Works great and by default doesn't change anything for existing installations...
I tried to make minimum changes to existing code, so I almost didn't refactor anything :-)

@mpost Please review, is this ready/acceptable to be pulled into main Calendar-Widget code? What should I do more before creating a "Pull request"?

[yvolk]

Another commit added: b0f1201 Fixed duplication of past and current events

[yvolk]

Attaching sample screenshot

[mpost]

@yvolk Looking at your proposed changes right now. Sorry i was on vacation. Could you please rebase on current master and provide a pull request so that we can more easily track comments on the proposed change?

From a first inspection the approach looks good. One thing that came to my mind is that i am not such a big fan of using a prefix string to denote past events. Couldn't we use some decreased alpha on the string to mark them as "past"? Coloring the past events background goes in the same direction. I wouldn't expect the past events (which are inherently less important) to use a signal color to make me aware of them.

One thing i didn't fully understand is how do we specify/limit the number of past events shown?

[yvolk]

Hi @mpost , thanks for asking :-)

1. "Could you please rebase on current master and provide a pull request so that we can more easily track comments on the proposed change?"
   [Edited:] Did this, see below.
2. "From a first inspection the approach looks good. One thing that came to my mind is that i am not such a big fan of using a prefix string to denote past events. Couldn't we use some decreased alpha on the string to mark them as "past"?"
   Sorry, I didn't fully understand, what you meant by "a prefix string to denote past events" :-) I use only different background color for them... The only (hidden) addition is excluding from the list of filtered events events, having "[C]" suffix: This helps migrating to the "Calendar Widget" from "Jorte Calendar", where "[C]" title suffix means "Completed event".
3. "Coloring the past events background goes in the same direction. I wouldn't expect the past events (which are inherently less important) to use a signal color to make me aware of them."
   The key point in this change is to show only events, which are important for a User for some reason. However I'm fully OK if you want to use any other default background color for past events as long as the color is customizable.
4. "One thing i didn't fully understand is how do we specify/limit the number of past events shown?"
   As all events filtered using this filter are considered important for a User, no date filtering is needed.
   Please note that showing all past events since some configured (relative) date/time (e.g. since midnight) should be IMHO a separate option!

[yvolk]

Hi @mpost , how can I help you to integrate this change into the master branch?