Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Support configurable tabsize for AST node position in reports #292

Open
adangel opened this issue Mar 11, 2017 · 3 comments
Open

[core] Support configurable tabsize for AST node position in reports #292

adangel opened this issue Mar 11, 2017 · 3 comments
Labels
an:enhancement An improvement on existing features / rules in:ast About the AST structure or API, the parsing step in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Milestone
7.x

Comments

@adangel
Copy link
Member

adangel commented Mar 11, 2017 •
edited
Loading

See #288 for an example.

There should be a property, that is configured via commandline/ant/... to configure the tabsize.
It's currently at the default value of 8.
Note: At least the Designer needs to be adjusted, too - since it also has a special tab handling, which is currently 8.

If the tabsize doesn't match your editor configuration, then you might have trouble finding the reported violation position.

And consider setting the tabsize to 4 by default for all languages, since this is the most common setting nowadays.
@jsotuyod
Copy link
Member

jsotuyod commented Mar 12, 2017 •
edited
Loading

Considering that we support multi-language analysis on a single run, and are considering taking it even further (#237) I think maybe ant / CLI is not the best approach (ie: I've seen way too often 4 spaces in Java, and 2 spaces on JSP / JS). Maybe extending the ruleset XML Schema to be able to configure per-language options such as these?

@adangel
Copy link
Member Author

adangel commented Mar 13, 2017

Yes, I agree, it needs to be language/parser specific. When extending the ruleset Schema, we should also have a look at this feature request. Looks like, we need something like a general section in the ruleset file - but still per language...

@jsotuyod jsotuyod added the an:enhancement An improvement on existing features / rules label Mar 13, 2017
@vn-ki-cn
Copy link

Any updates on this issue?

@oowekyala oowekyala mentioned this issue May 21, 2020
Closed
@maikelsteneker maikelsteneker mentioned this issue Jul 21, 2020
Merged
4 tasks
@adangel adangel added in:ast About the AST structure or API, the parsing step in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception labels Jan 13, 2023
@adangel adangel added this to the 7.x milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
an:enhancement An improvement on existing features / rules in:ast About the AST structure or API, the parsing step in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Projects
None yet
Milestone
7.x
Development

No branches or pull requests
3 participants
@jsotuyod @adangel @vn-ki-cn