-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plsql] updates should allow for multiple statements #1554
Conversation
Hi and thanks for the contribution! Could you remove the whitespace changes though? Your actual changes are lost in their noise, I have no idea what you modified. |
@oowekyala you can add |
@jsotuyod so cool, thanks! Then do ignore my comment tashiscool |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've created a corresponding bug report: #1583
Please see my question - I'm unsure whether the combination with ROW and columns is actually allowed in plsql.
@@ -1904,8 +1904,10 @@ ASTUpdateSetClause UpdateSetClause() : | |||
<SET> | |||
( | |||
<ROW> "=" ID() | |||
( "," Column() "=" ( Expression() | <_DEFAULT> )*)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? I didn't find a clear description, whether a ROW can be combined with single columns at the same time. The ROW uses a record, which contains all columns anyway...
So: Is this actually valid syntax?
UPDATE schedule
SET ROW = default_week,
Tue = 'Day Off'
WHERE week = 1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it, and I get this one:
ORA-06550: line 16, column 27:
PL/SQL: ORA-00933: SQL command not properly ended
ORA-06550: line 15, column 5:
PL/SQL: SQL Statement ignored
06550. 00000 - "line %s, column %s:\n%s"
*Cause: Usually a PL/SQL compilation error.
So, this combination is not possible....
Thanks for your contribution! This is merged and will be part of PMD 6.11.0. |
Before submitting a PR, please check that:
master
. The PMD team will merge back to support branches as needed../mvnw clean verify
passes. This will build and test PMD, execute PMD and checkstyle rules. Check this for more infoPR Description: