Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'FromMaybe' variant of GetFunction()->NewInstance() #50

Closed
wants to merge 1 commit into from
Closed

Use 'FromMaybe' variant of GetFunction()->NewInstance() #50

wants to merge 1 commit into from

Conversation

tim-janik
Copy link
Contributor

to avoid deprecation warning

Signed-off-by: Tim Janik timj@gnu.org

@tim-janik
Use 'FromMaybe' variant of GetFunction()->NewInstance() to avoid depr…
76069cc 
…ecation warning

Signed-off-by: Tim Janik <timj@gnu.org>
@pmed
Copy link
Owner

pmed commented Feb 19, 2017

Well, this moving to Maybe and MaybeLocal usage in V8 API is about 2 years, and as I understand is still not completed. There are many other places in v8pp where Maybe can be used instead of old partially deprecated functions.

So at the present I prefer not to break compatibility with older V8 versions, at least from version 4.10. I use preprocessor definitions V8_USE_UNSAFE_HANDLES and V8_DISABLE_DEPRECATIONS to continue the deprecated functions usage in my projects with v8pp.

But in general, you are right, and some time this should be done.

pmed added a commit that referenced this pull request Feb 4, 2018
@pmed
do not use deprecated V8 API functions
cd99252 
Updated implementation to recent V8 API changes:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
ab70573 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
f263139 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
c56c128 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
c56a717 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
d8030e5 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
e3c1603 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
47945ff 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
5c1d478 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile, switched
to `xenial` image (although it hasn't been officially released yet)

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
a8cf0f8 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile, switched
to `xenial` image (although it hasn't been officially released yet)

Related to #50 and #66
pmed added a commit that referenced this pull request Feb 10, 2018
@pmed
do not use deprecated V8 API functions
1ab6d8e 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated tests and examples.

Updated V8 versions in Travis script and Makefile, switched
to `xenial` image (although it hasn't been officially released yet)

Related to #50 and #66
@pmed
Copy link
Owner

pmed commented Feb 10, 2018

Done.

@pmed pmed closed this Feb 10, 2018
@tim-janik tim-janik deleted the v8-5.3.332.47 branch July 13, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tim-janik @pmed