Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8pp::set_const does not work in recent v8 versions (>6.0) #66

Closed
jcmonnin opened this issue Jan 20, 2018 · 2 comments
Closed

v8pp::set_const does not work in recent v8 versions (>6.0) #66

jcmonnin opened this issue Jan 20, 2018 · 2 comments

Comments

@jcmonnin
Copy link
Contributor

v8::Object::ForceSet with isolate as first argument has been removed in v8 6.1.

It looks like v8::Object::CreateDataProperty should be used in today's API. It looks like this is available since 4.5.

Before preparing a pull request, I'd like to ask what is the strategy with regards of the v8 API level. From the point of view of C++ applications using v8, I think it makes sense that actual version of v8pp targets recent versions of v8. If someone chooses not to update v8, he probably doesn't need to update v8pp either.

For node plugins the situation might look different (I don't know that part). It looks like the oldest supported LTS is 4 and node 4.8.7 seems to run v8 version 4.5. So it looks like it is time to use API's like CreateDataProperty (and other changes like using v8::Local instead of v8::Handle). Would pull requests breaking support of v8 before 4.5 be accepted?
@jcmonnin jcmonnin changed the title v8pp::set_const does not work recent v8 versions (>6.0) v8pp::set_const does not work in recent v8 versions (>6.0) Jan 20, 2018
@pmed
Copy link
Owner

pmed commented Jan 20, 2018

Hi Jean-Claude,

Thank you for raising this issue. Yes, I’ve already got the same a time ago. So pull request is welcomed. There was also a stalled branch local-handles, when I started to remove deprecated Handle usage.

I’m not sure what minimal V8 version support, 6.0 seems ok for me.

pmed added a commit that referenced this issue Feb 4, 2018
@pmed
Use v8::Object::DefineOwnProperty() instead of deprecated ForceSet()
6983d5d 
Fixed issue #66 and removed outdated preprocessor  definitions from
Visual Studio global project properties.
pmed added a commit that referenced this issue Feb 4, 2018
@pmed
do not use deprecated V8 API functions
cd99252 
Updated implementation to recent V8 API changes:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Related to #50 and #66
@jcmonnin jcmonnin closed this as completed Feb 9, 2018
@jcmonnin
Copy link
Contributor Author

jcmonnin commented Feb 9, 2018

Thanks for tackling the v8 API changes.

pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
ab70573 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
f263139 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
c56c128 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
c56a717 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
d8030e5 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
e3c1603 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
47945ff 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
5c1d478 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile, switched
to `xenial` image (although it hasn't been officially released yet)

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
a8cf0f8 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated V8 versions in Travis script and Makefile, switched
to `xenial` image (although it hasn't been officially released yet)

Related to #50 and #66
pmed added a commit that referenced this issue Feb 10, 2018
@pmed
do not use deprecated V8 API functions
1ab6d8e 
Updated implementation to V8 version 5.9:
  - use `v8::Local` instead of `v8::Handle`
  - use `v8::Global` instead of `v8::PersistentHandle`
  - use functions returning `MaybeLocal`

Updated tests and examples.

Updated V8 versions in Travis script and Makefile, switched
to `xenial` image (although it hasn't been officially released yet)

Related to #50 and #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmed @jcmonnin