ndctl: support machines without numa #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reworked patch: |
|
Looks good, go for it.
Thanks!!
…Sent from my iPhone
On Jan 4, 2017, at 6:26 PM, Dan Williams ***@***.***> wrote:
Reworked patch:
https://patchwork.kernel.org/patch/9498091/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
djbw
pushed a commit
that referenced
this pull request
Jan 5, 2017
Currently when using ndctl in machines that do not have numa, the ndctl command fails because it fails to find the numa_node attribute in systems. Just assume the default, zero, in these cases rather than fail. Link: #9 Signed-off-by: Diego Dompe <dompe@hpe.com> [djbw: minor style fixups] Signed-off-by: Dan Williams <dan.j.williams@intel.com>
djbw
pushed a commit
that referenced
this pull request
Jan 5, 2017
Currently when using ndctl with kernels compiled with CONFIG_NUMA=n, the ndctl command fails because it fails to find the numa_node attribute in systems. Just assume the default, zero, in these cases rather than fail. Link: #9 Signed-off-by: Diego Dompe <dompe@hpe.com> [djbw: minor style fixups] Reviewed-by: Jeff Moyer <jmoyer@redhat.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using ndctl in machines that doesn't have numa, the ndctl command fails because it fails to find the numa_node attribute in syses