Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

[gh-pages] add 'reports' sub-section with initial performance measurements #1048

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Oct 4, 2021

Preview:
https://lukaszstolarczuk.github.io/pmemkv/#performance-reports

// the external storage space is just too long waiting time, so for now we publish this one into GH; later on, we move on to the new storage place (I hope 😸 )


This change is Reviewable

@karczex
Copy link

karczex commented Oct 4, 2021


reports/index.md, line 1 at r2 (raw file):

---

Is reports directory really needed? Probably you may just add perdormace_reports.md to main directory. Or even add section to README.md.

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk changed the title [gh-pages] add 'reports' sub-dir with initial performance pdf [gh-pages] add 'reports' sub-section with initial performance measurements Oct 4, 2021
Copy link
Member Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @karczex and @KFilipek)


reports/index.md, line 1 at r2 (raw file):

Previously, karczex (Paweł Karczewski) wrote…

Is reports directory really needed? Probably you may just add perdormace_reports.md to main directory. Or even add section to README.md.

hah, good catch. Dir is not needed, but I think we may have this list of reports (perhaps not only performance ones) quite long, someday... so the separate reports.md seems like a good idea.

Copy link

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @KFilipek)

Copy link
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @KFilipek)

@lukaszstolarczuk lukaszstolarczuk merged commit 5c4ccfb into pmem:gh-pages Oct 5, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the add-perf-report branch October 5, 2021 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants